Skip to content

Fix crash during ALTER TABLE REMOVE SETTING in iceberg #99108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alesapin merged 3 commits into from
Mar 11, 2026
+34 −0
Merged

Fix crash during ALTER TABLE REMOVE SETTING in iceberg #99108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3e4b12
Fix crash during ALTER TABLE REMOVE SETTING in iceberg
alesapin Mar 9, 2026
9e5b54c
Better message
alesapin Mar 10, 2026
0924cd5
Merge remote-tracking branch 'origin/master' into fix_iceberg_alter_s…
alesapin Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,11 @@ void IcebergMetadata::checkAlterIsPossible(const AlterCommands & commands)
if (command.type != AlterCommand::Type::ADD_COLUMN && command.type != AlterCommand::Type::DROP_COLUMN
&& command.type != AlterCommand::Type::MODIFY_COLUMN && command.type != AlterCommand::Type::RENAME_COLUMN)
throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Alter of type '{}' is not supported by Iceberg storage", command.type);

if (command.type == AlterCommand::Type::MODIFY_COLUMN && command.to_remove != AlterCommand::RemoveProperty::NO_PROPERTY)
throw Exception(
ErrorCodes::NOT_IMPLEMENTED,
"Removing column property '{}' from column '{}' is not supported by Iceberg storage", command.to_remove, command.column_name);
}
}

Expand Down
1 change: 1 addition & 0 deletions tests/queries/0_stateless/04033_iceberg_alter_remove_settings_segfault.reference
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NOT_IMPLEMENTED
28 changes: 28 additions & 0 deletions tests/queries/0_stateless/04033_iceberg_alter_remove_settings_segfault.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#!/usr/bin/env bash
# Tags: no-fasttest

# Regression test for https://github.com/ClickHouse/ClickHouse/issues/86330
# ALTER TABLE ... MODIFY COLUMN ... REMOVE SETTINGS on an Iceberg table
# should return an error instead of causing a segfault.

CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
# shellcheck source=../shell_config.sh
. "$CURDIR"/../shell_config.sh

TABLE="t_${CLICKHOUSE_DATABASE}_${RANDOM}"
TABLE_PATH="${USER_FILES_PATH}/${TABLE}/"

${CLICKHOUSE_CLIENT} --query "DROP TABLE IF EXISTS ${TABLE}"
${CLICKHOUSE_CLIENT} --query "
CREATE TABLE ${TABLE} (c0 Int)
ENGINE = IcebergLocal('${TABLE_PATH}')
"
# To have at least one real snapshot. Otherwise alter can be noop.
${CLICKHOUSE_CLIENT} --allow_insert_into_iceberg=1 --query "INSERT INTO ${TABLE} VALUES (1)"

${CLICKHOUSE_CLIENT} --query "
ALTER TABLE ${TABLE} MODIFY COLUMN c0 REMOVE SETTINGS
" 2>&1 | grep -o -m1 "NOT_IMPLEMENTED"

${CLICKHOUSE_CLIENT} --query "DROP TABLE IF EXISTS ${TABLE}"
rm -rf "${TABLE_PATH}"