shell-like completion support in clickhouse keeper-client#99312
Merged
azat merged 3 commits intoClickHouse:masterfrom Mar 17, 2026
Merged
shell-like completion support in clickhouse keeper-client#99312azat merged 3 commits intoClickHouse:masterfrom
azat merged 3 commits intoClickHouse:masterfrom
Conversation
Contributor
|
Workflow [PR], commit [9d5ef4b] Summary: ❌
AI ReviewSummaryThis PR adds shell-like argument parsing and tab completion in Missing context
ClickHouse Rules
Final Verdict
|
clickhouse-gh
bot
added
the
pr-improvement
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
azat
force-pushed
the
keeper-improve-completion
branch
from
ff5c108 to
9fb2418
Compare
pufit
approved these changes
Mar 12, 2026
azat
force-pushed
the
keeper-improve-completion
branch
3 times, most recently
from
dba7d1b to
8cbdf0e
Compare
azat
force-pushed
the
keeper-improve-completion
branch
from
8cbdf0e to
d64c961
Compare
azat
force-pushed
the
keeper-improve-completion
branch
from
d64c961 to
8b865b2
Compare
azat
force-pushed
the
keeper-improve-completion
branch
2 times, most recently
from
a09bec6 to
bc15f8e
Compare
…g for ls) shell-like completion support in clickhouse keeper-client (handle completions of arguments in quotes, i.e. 'foo ba', handle escaped arguments, i.e. foo\ ba, make ls print quoted nodes, if they have whitespaces) Also remove on_complete_modify_callback hack, replace it with pure getCompletions implementation Co-Authored-By: Claude <noreply@anthropic.com>
azat
force-pushed
the
keeper-improve-completion
branch
from
bc15f8e to
9d5ef4b
Compare
Contributor
LLVM Coverage Report
PR changed lines: PR changed-lines coverage: 41.38% (132/319, 0 noise lines excluded) |
Merged
via the queue into
ClickHouse:master
with commit Mar 17, 2026
807a0c3
161 of 163 checks passed
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
shell-like completion support in clickhouse keeper-client (handle completions of arguments in quotes, i.e.
'foo ba', handle escaped arguments, i.e.foo\ ba, makelsprint quoted nodes, if they have whitespaces)Also remove
on_complete_modify_callbackhack, replace it with puregetCompletionsimplementationFollow-up for: #97828
Note
Medium Risk
Touches keeper-client parsing and interactive tab-completion logic, which can change how commands/paths are interpreted and may introduce edge-case regressions (escaping/quoting, multi-statement handling). Changes are CLI-scoped with added regression tests.
Overview
Adds shell-like path handling to
clickhouse-keeper-client: tab completion andlsoutput now round-trip node names that include spaces, backslashes, quotes, and other special characters via newformatKeeperNodeNameplus unescape/quote-aware completion logic.Reworks query processing to tokenize once and parse multiple statements directly (supporting escaped spaces and rejecting trailing garbage), and removes the
ReplxxLineReaderon_complete_modify_callbackTAB-binding hook across clients. Updates/extends stateless tests to cover the new escaping/quoting and completion behaviors.Written by Cursor Bugbot for commit bc15f8e. This will update automatically on new commits. Configure here.