Support Interval data types in Arrow Format#99519
Support Interval data types in Arrow Format#99519alexey-milovidov merged 20 commits intoClickHouse:masterfrom
Conversation
|
Workflow [PR], commit [10cdbe9] Summary: ✅ AI ReviewSummaryThis PR adds Arrow support for ClickHouse Missing context
ClickHouse Rules
Final Verdict
|
| 12::IntervalQuarter AS q, | ||
| 13::IntervalYear AS y | ||
| FORMAT $fmt | ||
| " | ${CLICKHOUSE_LOCAL} -q "SELECT * FROM file('-', '$fmt')" |
There was a problem hiding this comment.
IntervalNanosecond stopped being exported as Arrow DURATION(NANO) and became plain INT64).
Could we also assert the inferred types when reading back (e.g. via toTypeName/DESCRIBE on file('-', '$fmt')) so the test guards the new type mapping behavior, not only numeric payload preservation?
There was a problem hiding this comment.
This was a really great catch. There was existing code that made it return int64 for all interval types. Just fixed it.
…to IntervalNanosecond
|
@alexey-milovidov I believe the remaining failures are unrelated. Can we move forward regardless, or do you need me to keep retrying until it's all green? The |
|
Sorry, can't merge with failed checks. |
|
But the PR is good and approved, so as soon as we will fix them, we can merge. |
LLVM Coverage Report
PR changed lines: PR changed-lines coverage: 92.59% (75/81, 0 noise lines excluded) |
|
Thanks, this is a great change! |
|
Any chance this can be backported to 26.3 LTS? It will be quite sad to not have this in the LTS release for a long time. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Users can now write Clickhouse interval datatypes to the Arrow Format
Documentation entry for user-facing changes
Previously, queries that try to write interval data into Arrow format would encounter the following error.
Now, these queries work successfully.
Closes: #97849