Backport #97843 to 26.1: accept COMMENT before AS SELECT in view parser#99561
Merged
alexey-milovidov merged 2 commits into26.1from Mar 18, 2026
Merged
Backport #97843 to 26.1: accept COMMENT before AS SELECT in view parser#99561alexey-milovidov merged 2 commits into26.1from
alexey-milovidov merged 2 commits into26.1from
Conversation
…ibility Newer ClickHouse versions (26.2+) may format views as: CREATE VIEW ... COMMENT 'text' AS SELECT ... This makes the parser accept `COMMENT` both before and after `AS SELECT`, so views created on newer versions can be loaded by this release. Ref #97843 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Workflow [BackportPR], commit [2e6f576] Summary: ❌
|
The `formatQuery` function on the 26.1 branch outputs escaped single quotes (`\'test\'`) unlike master which outputs unescaped (`'test'`). Update the reference file to match the actual output. #99561 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMENTclause beforeAS SELECTin the view parser for forward compatibilityCOMMENTbeforeAS SELECTCOMMENTafterAS SELECTRef #97843
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Accept
COMMENTbeforeAS SELECTin view parser for forward compatibility with newer versions.🤖 Generated with Claude Code