tolerate missing padding at the end of the last block of parquet files#99857
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Mar 18, 2026
Conversation
Contributor
clickhouse-gh
bot
added
the
pr-improvement
alexey-milovidov
approved these changes
Mar 18, 2026
Contributor
LLVM Coverage Report
PR changed lines: PR changed-lines coverage: 92.86% (13/14, 0 noise lines excluded) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
tolerate missing padding at the end of the last block of parquet files
Details:
The Parquet spec requires zero-padding the last block to the full block size, but some writers (e.g. parquet-go) only write bytes for the actual values. The missing bytes correspond to padding values beyond total_values_remaining that would never be read by decodeImpl, so we reduce the miniblock's readable value count to match the available data.