[BugFix] fix the time measurement of run_queries.sh#96
Merged
rschu1ze merged 2 commits intoClickHouse:mainfrom Oct 13, 2025
Merged
[BugFix] fix the time measurement of run_queries.sh#96rschu1ze merged 2 commits intoClickHouse:mainfrom
rschu1ze merged 2 commits intoClickHouse:mainfrom
Conversation
murphyatwork
changed the title
Contributor
Author
|
I conducted a cold run test using various EBS specifications for Q2.
I didn't run the test on a slower EBS, but it would clearly take more than 60 seconds, potentially causing the exception. |
murphyatwork
commented
Oct 13, 2025
| # Execute the query multiple times | ||
| for i in $(seq 1 $TRIES); do | ||
| RESP=$(mysql -vvv -h "$DB_HOST" -P "$DB_MYSQL_PORT" -u"$DB_USER" "$DB_NAME" -e "$query" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' ||:) | ||
| RESP=$({ time -f '%e' \ |
Contributor
Author
There was a problem hiding this comment.
@rschu1ze annually /usr/bin/time is intended , which is different from time function and supports -f option.
Contributor
Author
There was a problem hiding this comment.
Could we re-run the test to update the results? I believe this will address the query failure issue from last time.
Contributor
Author
There was a problem hiding this comment.
thanks.
looks like the web page is not correctly updated?
This was referenced Oct 14, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
mysql -vvvmay produce output that isn't recognized by the regex, leading to an emptyResponse time. To address this, switch to/usr/bin/timefor measuring execution time.