Skip to content

[BugFix] fix the time measurement of run_queries.sh #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschu1ze merged 2 commits into from
Oct 13, 2025
Merged

[BugFix] fix the time measurement of run_queries.sh #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057cc79
fix the run_queries.sh
murphyatwork Oct 10, 2025
f876c57
Cosmetics
rschu1ze Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion starrocks/run_queries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ cat queries.sql | while read -r query; do

# Execute the query multiple times
for i in $(seq 1 $TRIES); do
RESP=$(mysql -vvv -h "$DB_HOST" -P "$DB_MYSQL_PORT" -u"$DB_USER" "$DB_NAME" -e "$query" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' ||:)
RESP=$({ time -f '%e' \
Copy link
Copy Markdown
Contributor Author

@murphyatwork murphyatwork Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rschu1ze annually /usr/bin/time is intended , which is different from time function and supports -f option.

Copy link
Copy Markdown
Member

@rschu1ze rschu1ze Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, thanks.

Fixed here: #97

Copy link
Copy Markdown
Contributor Author

@murphyatwork murphyatwork Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we re-run the test to update the results? I believe this will address the query failure issue from last time.

Copy link
Copy Markdown
Member

@rschu1ze rschu1ze Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #98

Copy link
Copy Markdown
Contributor Author

@murphyatwork murphyatwork Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.
looks like the web page is not correctly updated?

Copy link
Copy Markdown
Member

@rschu1ze rschu1ze Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #100

mysql -N -s -h "$DB_HOST" -P "$DB_MYSQL_PORT" -u"$DB_USER" "$DB_NAME" \
-e "$query" >/dev/null; } 2>&1)
echo "Response time: ${RESP} s"
done;
done;