Skip to content

Fix jdbc-v2: discard values list positions that do not address the original SQL - #3018

Open
polyglotAI-bot wants to merge 2 commits into
mainfrom
polyglot/jdbcv2-values-list-position-coordinates
Open

Fix jdbc-v2: discard values list positions that do not address the original SQL#3018
polyglotAI-bot wants to merge 2 commits into
mainfrom
polyglot/jdbcv2-values-list-position-coordinates

Do not treat parentheses inside SQL comments as structural in the val…

c1eb908
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 4, 2026 in 1m 10s

Annotations

Check warning on line 180 in jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/SqlParserFacade.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body.

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ_K51r7nTNtJqMtcl1j&open=AZ_K51r7nTNtJqMtcl1j&pullRequest=3018

Check failure on line 169 in jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/SqlParserFacade.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ_K51r7nTNtJqMtcl1m&open=AZ_K51r7nTNtJqMtcl1m&pullRequest=3018

Check warning on line 176 in jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/SqlParserFacade.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body.

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ_K51r7nTNtJqMtcl1i&open=AZ_K51r7nTNtJqMtcl1i&pullRequest=3018

Check warning on line 182 in jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/SqlParserFacade.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body.

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ_K51r7nTNtJqMtcl1k&open=AZ_K51r7nTNtJqMtcl1k&pullRequest=3018

Check warning on line 173 in jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/SqlParserFacade.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one.

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ_K51r7nTNtJqMtcl1l&open=AZ_K51r7nTNtJqMtcl1l&pullRequest=3018