test: retain e2e failure diagnostics and reports - #279
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves failure diagnostics for CI e2e runs and for the controller’s ClickHouse version-probe Job, making it easier to troubleshoot flaky or environment-specific failures in the ClickHouse operator’s test and reconciliation pipelines.
Changes:
- Persist namespace events as a diagnostic artifact during e2e test failures (in addition to printing them).
- Add a Ginkgo JSON report output for e2e tests and ensure reports are uploaded.
- Enhance version-probe failure visibility by falling back to container logs on error and enabling debug console logging; add CI steps to export/upload Kind + cluster state on failures.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/testutil/utils.go | Writes full namespace events dump to disk and prints the artifact path for easier CI retrieval. |
| Makefile | Adds --ginkgo.json-report for e2e test runs to retain structured test output. |
| internal/controller/versionprobe.go | Improves probe diagnostics via termination message fallback and debug console logging flags. |
| internal/controller/versionprobe_test.go | Updates unit tests to assert the new version-probe args and termination message policy. |
| .github/workflows/ci.yaml | On e2e failure, exports Kind logs + cluster snapshots and uploads them as artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Expose more details for CI and version probe failures
What
Collect more logs from kind in CI, expose more details in version probe