Support multi-statement cloud query files - #344
Closed
sdairs wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud service query --queries-fileinput into ClickHouse-aware statementsINSERT ... FORMATdata boundariesRoot cause
The Query API accepts one SQL statement per request, but the CLI read a query file into one string and submitted the entire file in a single request. Local
client --queries-filedelegates to the native ClickHouse client, which already processes multi-statement files.Impact
Multi-statement files, including
--queries-file -, now execute in file order. Authentication, service resolution, and any Query API provisioning happen once. Earlier statements and output remain visible if a later statement fails; statements after the failure are not submitted.Each statement is an independent Query API request, so persistent DDL/DML changes carry forward but connection-local state such as
USE,SET, temporary tables, and transactions does not.Stack
cloud service query --queries-filerejects multi-statement files that localclient --queries-fileaccepts #333Validation
cargo fmt --all --checkcargo build -p clickhousectl --all-targetscargo test -p clickhousectlcargo clippy -p clickhousectl --all-targets -- -D warnings