Phases feature by guyandtheworld · Pull Request #53 · Cloud-CV/evalai-cli

guyandtheworld · 2018-06-23T11:44:21Z

evalai challenge CHALLENGE phases
evalai challenge CHALLENGE phase PHASE

coveralls · 2018-06-23T11:46:05Z

Pull Request Test Coverage Report for Build 170

76 of 82 (92.68%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 90.523%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
evalai/utils/challenges.py	67	73	91.78%

Totals
Change from base Build 166:	0.5%
Covered Lines:	277
Relevant Lines:	306

💛 - Coveralls

RishabhJain2018 · 2018-06-24T18:58:21Z

@isht3 Please resolve the conflicts here.

RishabhJain2018 · 2018-06-25T09:28:17Z

@isht3 More conflicts 😄

RishabhJain2018 · 2018-06-25T09:30:58Z

evalai/utils/challenges.py

-    challenge = "{}{}{}{}".format(title, description, end_date, br)
+    cleaned_desc = BeautifulSoup(challenge["short_description"], "lxml").text
+    description = "{}\n".format(cleaned_desc)
+    date = "End Date : {}".format(style(challenge["end_date"].split("T")[0], fg="red"))


date -> end_date

RishabhJain2018 · 2018-06-25T09:31:35Z

evalai/utils/challenges.py

            echo("Sorry, no challenges found!")
+
+
+def pretty_print_challenge_phases(phases):


pretty_print_all_challenge_phases

RishabhJain2018 · 2018-06-25T09:32:16Z

evalai/utils/challenges.py

+        phase_id = "Phase ID: {}\n\n".format(style(str(phase["id"]),
+                                                   bold=True, fg="blue"))
+
+        title = "{} {} {}".format(phase_title, challenge_id, phase_id)


title -> phase_title

RishabhJain2018 · 2018-06-25T09:33:09Z

evalai/utils/challenges.py

+        echo(err)
+        sys.exit(1)
+
+    response_json = response.json()


response_json -> response

RishabhJain2018 · 2018-06-25T09:33:53Z

evalai/utils/challenges.py

+    pretty_print_challenge_phases(phases)
+
+
+def pretty_print_challenge_phase(phase):


pretty_print_challenge_phase_data

RishabhJain2018 · 2018-06-25T09:35:23Z

evalai/utils/challenges.py

+    is_active = style("\nActive : {}\n".format(phase["is_active"]), bold=True)
+    is_public = style("\nPublic : {}\n".format(phase["is_public"]), bold=True)
+
+    phase = "{}{}{}{}{}{}{}{}{}{}".format(title, description, start_date,


phase -> challenge_phase

guyandtheworld · 2018-06-25T10:18:00Z

@RishabhJain2018 Made changes! :D

RishabhJain2018 · 2018-06-26T03:27:37Z

evalai/utils/challenges.py

+    cleaned_desc = BeautifulSoup(challenge["short_description"], "lxml").text
+    description = "{}\n".format(cleaned_desc)
+    end_date = "End Date : {}".format(style(challenge["end_date"].split("T")[0], fg="red"))
+    date = "\n{}\n\n".format(style(end_date, bold=True))


@isht3 I think you missed this one date -> end_date

RishabhJain2018 · 2018-06-26T03:28:00Z

evalai/utils/challenges.py

+    description = "{}\n".format(cleaned_desc)
+    end_date = "End Date : {}".format(style(challenge["end_date"].split("T")[0], fg="red"))
+    date = "\n{}\n\n".format(style(end_date, bold=True))
+    challenge = "{}{}{}{}".format(title, description, date, br)


date -> end_date

RishabhJain2018 · 2018-06-26T03:28:58Z

evalai/utils/challenges.py

+
+def pretty_print_all_challenge_phases(phases):
+    """
+    Function to print all the challenge phase of a challenge.


Function to print all the challenge phases of a challenge

RishabhJain2018 · 2018-06-26T03:29:45Z

evalai/utils/challenges.py

+
+        cleaned_desc = BeautifulSoup(phase["description"], "lxml").text
+        description = "{}\n\n".format(cleaned_desc)
+        phase = "{}{}{}".format(phase_title, description, br)


phase -> challenge_phase

RishabhJain2018 · 2018-06-26T03:29:56Z

evalai/utils/challenges.py

+        cleaned_desc = BeautifulSoup(phase["description"], "lxml").text
+        description = "{}\n\n".format(cleaned_desc)
+        phase = "{}{}{}".format(phase_title, description, br)
+        echo(phase)


phase -> challenge_phase

RishabhJain2018 · 2018-06-26T03:46:58Z

tests/test_requests.py

        responses.add(responses.POST, url.format(API_HOST_URL, URLS.participate_in_a_challenge.value).format("2", "3"),
                      body=Exception('...'))

+        # Phases URLS


Phase URLS

RishabhJain2018 · 2018-06-26T03:47:20Z

tests/test_requests.py

+        self.expected = "Error: Sorry, the object does not exist."
+
+    @responses.activate
+    def test_display_phase_lists_for_object_does_not_exist(self):


Refer to function name comment above.

RishabhJain2018 · 2018-06-26T03:47:28Z

tests/test_requests.py

+        assert response == self.expected
+
+    @responses.activate
+    def test_display_phase_details_for_object_does_not_exist(self):


Refer to function name comment above.

RishabhJain2018 · 2018-06-26T03:47:35Z

tests/test_requests.py

        assert result.exit_code == -1
+
+    @responses.activate
+    def test_challenge_phase_lists_for_request_exception(self):


Refer to function name comment above.

RishabhJain2018 · 2018-06-26T03:47:39Z

tests/test_requests.py

+        assert result.exit_code == -1
+
+    @responses.activate
+    def test_challenge_phase_details_for_request_exception(self):


Refer to function name comment above.

RishabhJain2018 · 2018-06-26T06:05:52Z

tests/test_challenges.py

                      json=challenge_data, status=200)

-        challenges = challenge_data["results"]
+        challenges_json = challenge_data["results"]


ohh...okay!

RishabhJain2018 · 2018-06-26T06:16:18Z

tests/test_requests.py

        assert response == expected


+class TestDisplayPhasesWhenObjectDoesNotExist(BaseTestClass):


Just a minor change TestDisplayChallengePhasesWhenObjectDoesNotExist

* Fetch phase lists * Fetch phase details

RishabhJain2018

LGTM :)

RishabhJain2018 requested a review from varunagrawal June 23, 2018 14:11

guyandtheworld force-pushed the phases-feature branch 2 times, most recently from 6776349 to 2be6247 Compare June 23, 2018 19:50

guyandtheworld force-pushed the phases-feature branch from 2be6247 to 04a0e7b Compare June 25, 2018 09:08

RishabhJain2018 requested changes Jun 25, 2018

View reviewed changes

guyandtheworld force-pushed the phases-feature branch 2 times, most recently from 7f12a52 to c85a581 Compare June 25, 2018 10:17

RishabhJain2018 requested changes Jun 26, 2018

View reviewed changes

guyandtheworld force-pushed the phases-feature branch 2 times, most recently from d3bede5 to ed6711c Compare June 26, 2018 05:32

RishabhJain2018 requested changes Jun 26, 2018

View reviewed changes

Phase feature

5354b54

* Fetch phase lists * Fetch phase details

guyandtheworld force-pushed the phases-feature branch from ed6711c to 5354b54 Compare June 26, 2018 06:19

RishabhJain2018 approved these changes Jun 26, 2018

View reviewed changes

RishabhJain2018 merged commit a23fdf0 into master Jun 26, 2018

RishabhJain2018 deleted the phases-feature branch June 26, 2018 07:49

		echo("Sorry, no challenges found!")


		def pretty_print_challenge_phases(phases):

		pretty_print_challenge_phases(phases)


		def pretty_print_challenge_phase(phase):

		assert response == expected


		class TestDisplayPhasesWhenObjectDoesNotExist(BaseTestClass):

Conversation

guyandtheworld commented Jun 23, 2018 • edited by RishabhJain2018 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jun 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 170

💛 - Coveralls

Uh oh!

RishabhJain2018 commented Jun 24, 2018

Uh oh!

RishabhJain2018 commented Jun 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guyandtheworld commented Jun 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RishabhJain2018 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

guyandtheworld commented Jun 23, 2018 •

edited by RishabhJain2018

Loading

coveralls commented Jun 23, 2018 •

edited

Loading