fix: syncproxy module does not reload config file#1606
Merged
Conversation
0utplay
added
v: 4.X
derklaro
approved these changes
Apr 5, 2025
GiantTreeLP
pushed a commit
to GiantTreeLP/CloudNet
that referenced
this pull request
Jun 7, 2025
### Motivation An user reported that the `modules reload CloudNet-SyncProxy` command would reload the SyncProxy module but the module would not update the loaded configuration due to a wrongly placed `@Service` annotation. ### Modification Removed the wrong `@Service` annotation and the unnecessary null check. The management class is created by aerogel. If aerogel cannot find it / construct it, aerogel will throw an exception. ### Result The module configuration is properly reloaded on module reload. ##### Other context See https://discord.com/channels/325362837184577536/818777626663321671/1357362934732292187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
An user reported that the
modules reload CloudNet-SyncProxycommand would reload the SyncProxy module but the module would not update the loaded configuration due to a wrongly placed@Serviceannotation.Modification
Removed the wrong
@Serviceannotation and the unnecessary null check. The management class is created by aerogel. If aerogel cannot find it / construct it, aerogel will throw an exception.Result
The module configuration is properly reloaded on module reload.
Other context
See https://discord.com/channels/325362837184577536/818777626663321671/1357362934732292187