Skip to content

fix: syncproxy module does not reload config file #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0utplay merged 1 commit into from
Apr 5, 2025
Merged

fix: syncproxy module does not reload config file #1606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ...src/main/java/eu/cloudnetservice/modules/syncproxy/impl/node/CloudNetSyncProxyModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import eu.cloudnetservice.driver.module.ModuleLifeCycle;
import eu.cloudnetservice.driver.module.ModuleTask;
import eu.cloudnetservice.driver.module.driver.DriverModule;
import eu.cloudnetservice.driver.registry.Service;
import eu.cloudnetservice.driver.service.ServiceEnvironmentType;
import eu.cloudnetservice.modules.syncproxy.SyncProxyManagement;
import eu.cloudnetservice.modules.syncproxy.config.SyncProxyConfiguration;
Expand All @@ -38,11 +37,14 @@
import jakarta.inject.Singleton;
import java.nio.file.Files;
import lombok.NonNull;
import org.jetbrains.annotations.Nullable;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@Singleton
public final class CloudNetSyncProxyModule extends DriverModule {

private static final Logger LOGGER = LoggerFactory.getLogger(CloudNetSyncProxyModule.class);

@Inject
public CloudNetSyncProxyModule(@NonNull @Named("module") InjectionLayer<?> layer) {
layer.installAutoConfigureBindings(this.getClass().getClassLoader(), "syncproxy");
Expand Down Expand Up @@ -113,13 +115,12 @@ public void registerCommands(@NonNull CommandProvider commandProvider) {
}

@ModuleTask(lifecycle = ModuleLifeCycle.RELOADING)
public void handleReload(@Nullable @Service SyncProxyManagement management) {
if (management != null) {
management.configuration(this.loadConfiguration());
}
public void handleReload(@NonNull SyncProxyManagement management) {
management.configuration(this.loadConfiguration());
}

private @NonNull SyncProxyConfiguration loadConfiguration() {
LOGGER.debug("Loading SyncProxy module configuration");
return this.readConfig(
SyncProxyConfiguration.class,
() -> SyncProxyConfiguration.createDefault("Proxy"),
Expand Down
Loading