Add more timeout to mitigate ElementNotInteractableException#313
Merged
aleksei-burlakov merged 1 commit intoClusterLabs:masterfrom Apr 6, 2026
Conversation
mpagot
reviewed
Apr 2, 2026
|
|
||
| # Third, rename the cool_primitive to hot_primitive | ||
| time.sleep(2) # wait the redirect finishes | ||
| time.sleep(BIG_TIMEOUT) # wait the redirect finishes |
There was a problem hiding this comment.
I do not know much about Selenium in particular but I know that, generally speaking, web test framework has dedicated way to wait for page loading or redirection. Maybe in this or next PR we can explore one of these ExpectedConditions, urlMatches, urlContains, urlToBe
Contributor
There was a problem hiding this comment.
I think it's not too bad. BIG_TIMEOUT is 6: https://github.com/ClusterLabs/hawk/blob/master/e2e_test/hawk_test_driver.py#L20
But yes, generally is better to wait for a condition.
alvarocarvajald
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please allow me to add more timeout to mitigate randomly selenium.common.exceptions.StaleElementReferenceException or selenium.common.exceptions.ElementNotInteractableException.
Ticket: https://jira.suse.com/browse/TEAM-11084
VR:
https://openqa.suse.de/tests/21633024
https://openqa.suse.de/tests/21633020
https://openqa.suse.de/tests/21633012
https://openqa.suse.de/tests/21633007
https://openqa.suse.de/tests/21633004