build: fix out-of-tree build broken with 0b04ed5 (#184) #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating the man pages definitely doesn't depend on existence of (possibly generated) header files that we omit anyway.
Although this is not as rigorously correct as the previous arrangement (introduced with 80834ea), i.e., from the perspective of $(abs_top_builddir)/tests/Makefile (generated from from $(top_srcdir)/tests/Makefile.am), for which $(top_builddir) is literally "..": - qbconfig.h is generated from $(top_srcdir)/include/qb/qbconfig.h.in into $(top_builddir)/include/qb directory, and consumed from here - rest of these header files are consumed directly from $(top_srcdir)/include/qb directory this new simplified variant: - avoids code duplication (DRY) - works thanks to VPATH in $(abs_top_builddir)/tests/Makefile pointing to $(top_srcdir)/tests, which means that unsatisfied dependencies on "$(top_builddir)/include/qb/%.h" (resolved to "../include/qb/%.h") will be subsequently sought as "$(top_srcdir)/tests/../include/qb/%.h", which has the same effect as previous explicit "$(top_srcdir)/include/qb/%.h" specification (note that such automatic VPATH provision is supported by automake "since beginning" so no backward incompatibility is expected)
jnpkrn
force-pushed
the
reenable-out-of-tree-build
branch
from
1ae36f4 to
328f99e
Compare
Previously, stuffing CLEANFILES with anything would not work in the affected files.
This required moving the test programs over from *_PROGRAMS and hooking the respective build recipe under explicit "check" target.
jnpkrn
force-pushed
the
reenable-out-of-tree-build
branch
from
dab8170 to
9107af6
Compare
This is to allow running auto_header_check-based tests independently of the rest of the (possibly lengthy) tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the man pages definitely doesn't depend on existence of
(possibly generated) header files that we omit anyway.