array: More locking fixes #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helgrind threw out a couple more locking errors in the logging/array code.
Member
|
Looks good but I have one question. Is it safe to access |
Contributor
Author
|
Hmm good question. Helgrind didn't complain about it but that's not a guarantee |
jfriesse
approved these changes
Jun 8, 2020
Member
jfriesse
left a comment
jfriesse
left a comment
There was a problem hiding this comment.
Ok, helgrind is usually right so ACK because patch improves locking for sure. We may consider more enhancements if it shows as needed later.
Contributor
Author
|
thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helgrind threw out a couple more locking errors in the logging/array
code.