feat: make samply profiler default for all OSes - #472
Merged
GuillaumeLagrange merged 3 commits intoJul 27, 2026
Conversation
Greptile SummaryUpdates wall-time profiling behavior and test infrastructure:
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/executor/wall_time/executor.rs | Changes the default wall-time profiler selection to Samply on every platform. |
| src/cli/mod.rs | Adds an environment override for the executable used to dispatch internal Samply commands. |
| src/executor/tests.rs | Builds real workspace binaries on demand and supplies them to wall-time executor tests. |
| .github/workflows/ci.yml | Removes the redundant exec-harness installation from the main test job. |
| Cargo.toml | Adds Escargot as a development dependency for test-time Cargo builds. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Wall-time execution requested] --> B{Profiler override}
B -->|Perf| C[PerfProfiler]
B -->|Samply| D[SamplyProfiler]
B -->|None| D
D --> E[Internal Samply command]
E --> F{CODSPEED_SELF_EXE set?}
F -->|Yes| G[Re-execute configured binary]
F -->|No| H[Re-execute current executable]
Reviews (3): Last reviewed commit: "feat: make samply profiler default for a..." | Re-trigger Greptile
Merging this PR will not alter performance
|
Tests no longer require sudo, or at least they dont after the kernel parameters are set, and the memory executor tests now run in a reasonable time thanks to the attach on demand, we dont need to gate anymore. Also add a way for the test executable to find the actual codspeed binary in order to have the self exec into samply work properly. It used to re-exec the test executable, which is not the behavior we want here.
GuillaumeLagrange
force-pushed
the
cod-2796-switch-to-samply-profiler-by-default
branch
from
July 27, 2026 12:21
cd39f10 to
c6f4fe8
Compare
not-matthias
approved these changes
Jul 27, 2026
GuillaumeLagrange
deleted the
cod-2796-switch-to-samply-profiler-by-default
branch
July 27, 2026 14:51
GuillaumeLagrange
added a commit
that referenced
this pull request
Jul 27, 2026
* feat(samply-codspeed): bump submodule to forward signal exit code * chore: fix self-exec failures in tests and ungate executor tests Tests no longer require sudo, or at least they dont after the kernel parameters are set, and the memory executor tests now run in a reasonable time thanks to the attach on demand, we dont need to gate anymore. Also add a way for the test executable to find the actual codspeed binary in order to have the self exec into samply work properly. It used to re-exec the test executable, which is not the behavior we want here. * feat: make samply profiler default for all OSes
GuillaumeLagrange
added a commit
that referenced
this pull request
Jul 27, 2026
* feat(samply-codspeed): bump submodule to forward signal exit code * chore: fix self-exec failures in tests and ungate executor tests Tests no longer require sudo, or at least they dont after the kernel parameters are set, and the memory executor tests now run in a reasonable time thanks to the attach on demand, we dont need to gate anymore. Also add a way for the test executable to find the actual codspeed binary in order to have the self exec into samply work properly. It used to re-exec the test executable, which is not the behavior we want here. * feat: make samply profiler default for all OSes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.