Skip to content

Added disposable for HTTPListener #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanielh merged 2 commits into from
Apr 25, 2018
Merged

Added disposable for HTTPListener #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1125f12
Added disposable for HTTPListener
gavazquez Apr 25, 2018
0a2ea28
Removed null check
gavazquez Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions uhttpsharp/Listeners/IHttpListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
using System.Threading.Tasks;
using System;
using System.Threading.Tasks;
using uhttpsharp.Clients;

namespace uhttpsharp.Listeners
{
public interface IHttpListener
public interface IHttpListener: IDisposable
{

Task<IClient> GetClient();

}
}
}
7 changes: 6 additions & 1 deletion uhttpsharp/Listeners/SslListenerDecoerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,10 @@ public async Task<IClient> GetClient()
{
return new ClientSslDecorator(await _child.GetClient().ConfigureAwait(false), _certificate);
}

public void Dispose()
{
_child.Dispose();
}
}
}
}
5 changes: 5 additions & 0 deletions uhttpsharp/Listeners/TcpListenerAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,10 @@ public async Task<IClient> GetClient()
{
return new TcpClientAdapter(await _listener.AcceptTcpClientAsync().ConfigureAwait(false));
}

public void Dispose()
{
_listener.Stop();
}
}
}