Fix BOM-prefixed Windows cleanup selection JSON - #3
Closed
rodion-m wants to merge 2 commits into
Closed
Conversation
Windows PowerShell Set-Content -Encoding UTF8 writes a BOM that made apply-cleanup-selection.py fail before dry-run/apply. Load selection files with utf-8-sig (and the scan data path in render-cleanup-plan) and cover BOM + BOM-less inputs in the validator regression suite. Fixes #1
2 tasks
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Member
Author
|
Closing this replacement: the maintainer will preserve and merge the original contributor PR #2 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Windows PowerShell and some editors can emit a UTF-8 BOM. Reading with
encoding="utf-8"preserves the leading marker, which causesjson.loadsto reject otherwise valid JSON.utf-8-sigremoves the marker when present and behaves like UTF-8 when it is absent.Safety
mainskills/agents-consilium/prompt.mdorprompt.txtValidation
python3 skills/maintaining-windows-health/assets/test_validate_command.py— 56 passed, 0 failedpython3 -m py_compilefor all three changed Python filesgit diff --checkgitleaks dir— no leaks foundjqSupersedes #2 while preserving the original contributor's implementation and authorship.
Fixes #1