Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ name: release-please
on:
push:
branches: [main]
workflow_dispatch:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin manually dispatched releases to main

When a maintainer selects a non-main branch in the workflow-dispatch branch picker, the action's omitted target-branch input defaults to the branch on which the workflow is running, as documented in the v4 action inputs. Repeated manual runs can therefore prepare and publish a release from a feature branch even though the existing automatic trigger is intentionally restricted to main; set target-branch: main or reject dispatches whose ref is not main.

Useful? React with 👍 / 👎.

inputs:
release_as:
description: 'Optional version to force, for example 1.10.0. Leave empty to use Conventional Commits.'
type: string
required: false

permissions:
contents: write
Expand All @@ -21,6 +27,7 @@ jobs:
id: release
with:
token: ${{ secrets.GITHUB_TOKEN }}
release-as: ${{ inputs.release_as || '' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pass the forced version through a supported mechanism

When a manual run supplies release_as, googleapis/release-please-action@v4 does not declare or consume a release-as input; it is absent from the action's v4 input metadata. GitHub therefore reports this as an unexpected input and the action falls back to ordinary manifest/Conventional Commit detection, so the requested version can be silently ignored and the run may create no release PR or propose the wrong version. Use a supported release-please configuration or CLI mechanism to apply the forced version.

Useful? React with 👍 / 👎.


# Move the moving major tag here rather than in release-major-tag.yml: a
# release created with GITHUB_TOKEN does NOT trigger other workflows, so the
Expand Down
Loading