Feature/auto update - #5
Merged
Merged
Conversation
… error information, dependency upgrades, refactoring
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 17 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+154
to
+161
| let update_server = state.settings.update_server.clone(); | ||
| let (_, open) = window::open(settings); | ||
| ( | ||
| Self { | ||
| windows: BTreeMap::new(), | ||
| state: State::default(), | ||
| state, | ||
| image_service: ImageService::new(), | ||
| update_service: UpdateService::new(update_server), |
There was a problem hiding this comment.
The update_service field is initialized once in App::new() using the update_server URL from the loaded settings. If the update_server setting is ever changed at runtime and saved (even though no UI currently exposes this field), the update_service will continue to use the original URL because it is never re-created. Consider re-creating the UpdateService from the current settings whenever CheckForUpdates is triggered, or store only the URL and create a fresh client each time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.