Skip to content

Chore/sync upstream jul 2026 - #66

Open
VinneyJ wants to merge 3002 commits into
mainfrom
chore/sync-upstream-jul-2026
Open

Chore/sync upstream jul 2026#66
VinneyJ wants to merge 3002 commits into
mainfrom
chore/sync-upstream-jul-2026

Conversation

@VinneyJ

@VinneyJ VinneyJ commented Jul 20, 2026

Copy link
Copy Markdown

Summary

What's included

Key upstream changes brought in:

  • Domain renewals & Stripe domain billing flows
  • Partner fraud detection & identity verification
  • Program onboarding improvements & image upload fixes
  • Social metrics bounties visibility
  • API log route coverage & secret masking
  • Payouts upgrade messaging
  • QStash withCron wrapper across cron handlers
  • Various bug fixes and UI improvements

Test plan

  • Verify app builds without errors
  • Smoke test login and workspace loading
  • Check domain and partner flows still work

steven-tey and others added 30 commits July 3, 2026 15:42
Move "link.clicked" webhook to workspace level
…ntity

Bound eventQuantity to a positive integer with a max
…form-response

Rate limit SAML verify and unify not-found/no-SSO response
Allow min payout for whitelisted workspaces
Removed the update logic for partner bank account when application access is revoked. Added a TODO to recompute payout state if necessary.
VinneyJ added 3 commits July 16, 2026 10:01
…op-2026-07-16

# Conflicts:
#	apps/web/app/(ee)/api/events/export/route.ts
#	apps/web/app/(ee)/api/events/route.ts
#	apps/web/next.config.js
#	packages/email/src/resend/constants.ts
#	packages/email/src/send-via-resend.ts
#	pnpm-lock.yaml
Left out of the import when resolving the merge conflict in
packages/email/src/send-via-resend.ts; caught by tsc --noEmit.
@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dub Error Error Jul 29, 2026 6:55am

Request Review

VinneyJ and others added 2 commits July 27, 2026 13:53
- Add FORWARD_QUERY directives to datasources with schema changes
  (dub_click_events, dub_sale_events, dub_lead_events,
   dub_api_logs, dub_links_metadata)
- Add partner_tag_ids to dub_links_metadata_pipe explicit column list
- Add dub_regular_links_metadata_latest datasource and materialization
- Add v2 endpoint pipes from Classic workspace (endpoints/ directory)
- Add tinybird.config.json for Forward workspace configuration
- Add backup script for pre-migration data export
…ation

Migrate Tinybird workspace from Classic to Forward
@VinneyJ

VinneyJ commented Jul 28, 2026

Copy link
Copy Markdown
Author

Of course, the review for this would be a long shot. But the approval is still important before the merge. @kilemensi , @maquchizi

@kilemensi

kilemensi commented Jul 28, 2026

Copy link
Copy Markdown
Member

Reviewing this is not difficult @VinneyJ , it is impossible! But as long as we don't introduce any changes all should be good.

Lets see if codex can do:

@codex review if this PR only pull changes from upstream repo or introduces own changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

{
"dev_mode": "manual",
"folder": "."
}

P1 Badge Split the Tinybird migration from the upstream sync

The preserved branch history shows that this configuration was added by the downstream commit a73faa6f (“Migrate Tinybird workspace from Classic to Forward”), after upstream commit 28b7f9cc had already been merged, and was followed by several additional downstream Tinybird commits. This means the proposed commit includes an independent data-infrastructure migration rather than only upstream changes; it should be removed from this sync and reviewed separately.


"app.fyi.codeforafrica.org",
"dub.dev.codeforafrica.org",

P2 Badge Split the downstream hostname additions from the sync

These Code for Africa hostnames are not present in the synced upstream tree: repository history attributes them to downstream commit f97b055f, created after the upstream merge. They change which requests the middleware treats as application traffic, so this commit is not an upstream-only pull unless these lines are removed or moved to a separately reviewed change.


domain: VERCEL_DEPLOYMENT
? process.env.NEXTAUTH_COOKIE_DOMAIN || ".dub.co"
: undefined,

P2 Badge Split the configurable cookie-domain behavior from the sync

The NEXTAUTH_COOKIE_DOMAIN fallback was introduced by downstream commit efd9b4fc after the upstream merge, rather than by upstream through PR dubinc#4168. Because this changes the scope of production session cookies and is independent behavior not mentioned as an upstream change, it should be separated from an upstream-only synchronization.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@VinneyJ

VinneyJ commented Jul 28, 2026

Copy link
Copy Markdown
Author

@codex, review once more and check whether P1 is still in this PR. P2 should be fine for this PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d03cf63a71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -326,8 +383,8 @@ export const authOptions: NextAuthOptions = {
path: "/",
// When working on localhost, the cookie domain must be omitted entirely (https://stackoverflow.com/a/1188145)
domain: VERCEL_DEPLOYMENT
? `.${process.env.NEXT_PUBLIC_APP_DOMAIN}`
: undefined,
? process.env.NEXTAUTH_COOKIE_DOMAIN || ".dub.co"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the self-hosted session cookie domain

On any Vercel-backed self-host whose hostname is outside dub.co—including the newly added app.fyi.codeforafrica.org and dub.dev.codeforafrica.org hosts—this defaults the cookie to Domain=.dub.co unless the new NEXTAUTH_COOKIE_DOMAIN variable is manually configured. Browsers reject that cookie because its domain does not match the response host, so authentication cannot persist. A repo-wide search at this commit finds no declaration or example for the new variable, while the previous implementation derived the domain from the existing required NEXT_PUBLIC_APP_DOMAIN; retain that fallback or include and migrate the required configuration.

Useful? React with 👍 / 👎.

@VinneyJ

VinneyJ commented Jul 28, 2026

Copy link
Copy Markdown
Author

@kilemensi I think it's good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants