Chore/sync upstream jul 2026 - #66
Conversation
Move "link.clicked" webhook to workspace level
…ntity Bound eventQuantity to a positive integer with a max
…form-response Rate limit SAML verify and unify not-found/no-SSO response
Allow min payout for whitelisted workspaces
Removed the update logic for partner bank account when application access is revoked. Added a TODO to recompute payout state if necessary.
…op-2026-07-16 # Conflicts: # apps/web/app/(ee)/api/events/export/route.ts # apps/web/app/(ee)/api/events/route.ts # apps/web/next.config.js # packages/email/src/resend/constants.ts # packages/email/src/send-via-resend.ts # pnpm-lock.yaml
Left out of the import when resolving the merge conflict in packages/email/src/send-via-resend.ts; caught by tsc --noEmit.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add FORWARD_QUERY directives to datasources with schema changes (dub_click_events, dub_sale_events, dub_lead_events, dub_api_logs, dub_links_metadata) - Add partner_tag_ids to dub_links_metadata_pipe explicit column list - Add dub_regular_links_metadata_latest datasource and materialization - Add v2 endpoint pipes from Classic workspace (endpoints/ directory) - Add tinybird.config.json for Forward workspace configuration - Add backup script for pre-migration data export
…ation Migrate Tinybird workspace from Classic to Forward
|
Of course, the review for this would be a long shot. But the approval is still important before the merge. @kilemensi , @maquchizi |
💡 Codex Reviewdub/packages/tinybird/tinybird.config.json Lines 1 to 4 in fb38e90 The preserved branch history shows that this configuration was added by the downstream commit dub/packages/utils/src/constants/main.ts Lines 6 to 7 in fb38e90 These Code for Africa hostnames are not present in the synced upstream tree: repository history attributes them to downstream commit dub/apps/web/lib/auth/options.ts Lines 385 to 387 in fb38e90 The ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex, review once more and check whether P1 is still in this PR. P2 should be fine for this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d03cf63a71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -326,8 +383,8 @@ export const authOptions: NextAuthOptions = { | |||
| path: "/", | |||
| // When working on localhost, the cookie domain must be omitted entirely (https://stackoverflow.com/a/1188145) | |||
| domain: VERCEL_DEPLOYMENT | |||
| ? `.${process.env.NEXT_PUBLIC_APP_DOMAIN}` | |||
| : undefined, | |||
| ? process.env.NEXTAUTH_COOKIE_DOMAIN || ".dub.co" | |||
There was a problem hiding this comment.
Preserve the self-hosted session cookie domain
On any Vercel-backed self-host whose hostname is outside dub.co—including the newly added app.fyi.codeforafrica.org and dub.dev.codeforafrica.org hosts—this defaults the cookie to Domain=.dub.co unless the new NEXTAUTH_COOKIE_DOMAIN variable is manually configured. Browsers reject that cookie because its domain does not match the response host, so authentication cannot persist. A repo-wide search at this commit finds no declaration or example for the new variable, while the previous implementation derived the domain from the existing required NEXT_PUBLIC_APP_DOMAIN; retain that fallback or include and migrate the required configuration.
Useful? React with 👍 / 👎.
|
@kilemensi I think it's good now. |
Summary
ResendBulkEmailOptionsimportWhat's included
Key upstream changes brought in:
withCronwrapper across cron handlersTest plan