Configurable background and text colour for ContentOverview and Testimonial

[koechkevin]

Summary

Extends the OpportunitiesList colour pattern to the ContentOverview and Testimonial blocks, so editors can set the section background and text colour from the CMS instead of relying on hard-coded values.

Changes

Each block now exposes backgroundColor and textColor via the shared colorSettingsField (defaults #fff / #000, rendered by the native ColourPicker), and each component applies them on its root Box (background + color):

File	Change
payload/blocks/ContentOverview.js	Add colorSettingsField (bg #fff, text #000)
components/ContentOverview/ContentOverview.js	Read backgroundColor/textColor; apply on root Box, replacing hard-coded common.white
components/ContentOverview/ContentOverview.snap.js	Snapshot update (root Box class hash)
payload/blocks/Testimonial.js	Add colorSettingsField (bg #fff, text #000)
components/Testimonial/Testimonial.js	Read backgroundColor/textColor; apply on root Box, replacing hard-coded #fff

Screenshots

Testing

• eslint clean on all changed files.
• ContentOverview: 5 tests + snapshots pass. Testimonial: 7 tests pass.

[koechkevin]

@claude review

[claude]

Claude finished @koechkevin's task in 1m 43s —— View job

---

Code Review

• Gather context and understand the request
• Read changed files
• Analyze for bugs, security issues, and best practices
• Post review findings

---

Overall the approach is clean and consistent with the OpportunitiesList pattern. Two items worth addressing, one of which is functional.

---

textColor has limited effect in ContentOverview

This is the main concern. Setting color: textColor on the root Box relies on CSS inheritance to propagate the colour to child elements. However, nearly every text element in ContentOverview sets an explicit hardcoded color in its sx style object, which takes precedence over inherited values:

// ContentOverview.js – static sx objects with hardcoded colours
const headingSx       = { ..., color: "#0A1628" };
const bodySx          = { ..., color: "#252B37" };
const cardTitleSx     = { ..., color: "#0A1628" };
const cardRichTextBodySx = { ..., color: "#3E4159" };
const itemLabelSx     = { ..., color: "#3E4159" };
const itemLinkSx      = { ..., color: "#1020E1" };
const itemValueSx     = { ..., color: "#3E4159" };

Because these sx declarations always win over inherited color, an editor who sets a white text colour on a dark background will see no change in any of those elements — the text will still render with its hardcoded dark colour. The textColor prop is effectively a no-op for the visible content of ContentOverview.

Contrast with Testimonial, where the title Typography only sets fontWeight/mb (no color), and LexicalRichText's TypographyProps only sets lineHeight — so textColor inheritance works correctly there.

To fix this in ContentOverview, the static sx objects would need to be converted to dynamic sx functions/callbacks that read from props (or accept textColor as a parameter), so the colour slots can be derived from textColor rather than hardcoded. Fix this →

---

Minor: background vs backgroundColor shorthand

OpportunitiesList (the reference pattern being followed) uses the CSS background shorthand:

// OpportunitiesList.js:246
sx={{ background: backgroundColor, color: textColor, ...sx }}

Both ContentOverview and Testimonial use backgroundColor instead. backgroundColor is actually the more precise choice (it won't accidentally reset background-image), but it's a minor inconsistency with the established pattern. Fine to keep as-is.

---

Everything else looks good

• Payload block definitions are correct — colorSettingsField is called with the right overrides, CMS defaults (#fff/#000) match the component-level prop defaults.
• The colorSettingsField base default for textColor is #FFFFFF but the textOverrides: { defaultValue: "#000" } override correctly changes it to black for both blocks.
• Testimonial changes are clean — backgroundColor and color: textColor work correctly there since child text styles don't override the inherited colour.
• Snapshot hashes change due to the sx change on the root Box (from backgroundColor: "common.white" to backgroundColor: "#fff" + color: "#000"). Correct.
• The colorSettingsField placement in the ContentOverview payload block (between content and card) is reasonable CMS UX.

[kilemensi]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17cfd1ad62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".