Skip to content

C4GT 2024 Frontend#959

Merged
riya-2206 merged 24 commits into
mainfrom
feat/c4gt-2024-navbar
Jun 19, 2024
Merged

C4GT 2024 Frontend#959
riya-2206 merged 24 commits into
mainfrom
feat/c4gt-2024-navbar

Conversation

@riya-2206

Copy link
Copy Markdown
Collaborator

Have added react components in order to fetch the issue details

@riya-2206
riya-2206 requested a review from karntrehan June 19, 2024 06:21
@riya-2206 riya-2206 self-assigned this Jun 19, 2024
@vercel

vercel Bot commented Jun 19, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c4gt-milestones ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 7:33am

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please show error if it exists, don't return empty fragments.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am showing error if error exists
image

Comment thread src/components/Sidebar.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using inline styling wherever possible

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have removed it for many places will try to remove for other places also

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the weeklyGoals and weeklyLearnings code do?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was there to handle md I will remove this code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please show error if there exists any.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is there already

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same things here too

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this also I am showing error

@amit-s19 amit-s19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riya-2206
riya-2206 merged commit 3a1f1b5 into main Jun 19, 2024
@riya-2206
riya-2206 deleted the feat/c4gt-2024-navbar branch July 1, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants