docs(config): document the robinhood probe's key names in .env.example - #219
Merged
Conversation
`scripts/robinhood_smoke.py` (#216) has required `ROBINHOOD_API_KEY` and `ROBINHOOD_PRIVATE_KEY` since it landed, and #218 exercised it against the live venue twice, but neither PR added the names to `.env.example` -- so the only record of what to put in `.env` was the script's own failure message, which you see after you already went looking. Both are commented as probe-only on purpose. `load_secrets` does not read them, so a reader who fills them in and expects the adapter to come alive in a run has misread the state of this package; the README says the same thing at length and this is the one-line version at the point of use. The seed encoding is called out because a PEM is the likelier guess and fails with a length error rather than anything that names the cause. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/robinhood_smoke.py(#216) has requiredROBINHOOD_API_KEYandROBINHOOD_PRIVATE_KEYsince it landed, and #218 exercised it against the live venue twice, but neither PR added the names to.env.example. The only record of what to put in.envwas the script's own failure message — which you only see after you already went looking.What changed
Two names and a four-line comment in
.env.example. Nothing executable.Why the comment carries its weight
load_secretsdoes not read these. A reader who fills them in and expects the Robinhood adapter to come alive in a run has misread the state of the package. The adapter README says so at length; this is the one-line version at the point of use.Verification
uv run pytest tests/broker_robinhood tests/scripts/test_robinhood_smoke.py -q→ 167 passed (unchanged; this PR touches no code).packages/keel-broker-robinhood/README.md:121-122, the seed encoding againstscripts/robinhood_smoke.py:191.🤖 Generated with Claude Code