docs(review-path): the scholarly-review stance — not reviewed, path defined (#289) - #318
Merged
Conversation
…eviewed, with the path defined (#289)
…ions scope reconciled; conditional phrasing throughout
This was referenced Aug 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #289. Decides the scholarly-review question the honest way the issue demands: keel offers option 3, said out loud — no scholarly review has occurred — in the README's first screen and in a new "Scholarly review status" section of docs/fiqh-basis.md. Alongside the disclaimer, the review path is fully defined (option 2's machinery, documented as a path, not a claim): what a review will cover, what a reviewer is and is not endorsing, how a review is recorded as a dated addendum that can only ratchet from not-reviewed to reviewed-with-a-named-scope, and the outreach shortlist (IIUM, INCEIF, Durham, Islamic fintech practitioners) with a ready-to-send note. The approach itself is the operator's action and is stated as not taken.
Tests-first evidence
tests/test_scholarly_review.py written first: red run showed 8 failed / 1 passed (the negative no-false-claims test passes trivially before any doc exists — it exists to guard afterwards). After the two insertions (README paragraph after the boundary blockquote; the status section between "How to disagree" and "Sources index"): 9 passed. The pinned no-review sentence — "No scholarly review of keel's fiqh basis has occurred" — is asserted identically in the README first screen and the status section, and the negative test scans README/CONTRIBUTING/fiqh-basis for affirmative overstatement phrasings ("scholar-approved", "reviewed and approved", "certified", "endorsed by", …) so the claim can never quietly soften or inflate.
Gates
uv run ruff check keel tests packages— All checks passed!uv run mypy— Success: no issues found in 234 source filesuv run pytest -q— 2832 passed, 1 skippedScope check