chore(release): update uv.lock to 0.10.0 - #423
Merged
Merged
Conversation
#422 bumped the version in all seven `pyproject.toml` files and missed `uv.lock`, which is tracked and still pinned every workspace member at 0.9.3. The release workflow's "Sync dependencies" step then regenerated it, which left the checkout DIRTY, and the build stamped from that checkout identified itself as keel 0.10.0+29464f06ee11 (DIRTY) [release] so "Verify the artifact identifies itself" refused to go on. That guard did exactly its job: a `(DIRTY)` build corresponds to no commit, and `docs/RELEASING.md` is explicit that such a build must never run against live funds. Nothing was tagged and nothing was published. Regenerated with `uv lock`, which touches only the seven workspace members' versions -- no dependency resolution moved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failed
0.10.0release run: https://github.com/CodeGateSoftware/keel/actions/runs/32316126013What happened
#422 bumped the version in all seven
pyproject.tomlfiles and misseduv.lock, which is tracked and still pinned every workspace member at0.9.3.The workflow's "Sync dependencies" step regenerated it, which left the checkout dirty. "Stamp build info" then stamped a build from that dirty checkout, and
keel --versionreported:The guard did exactly its job.
version.build_info()re-checksgit status --porcelainagainst the stamp rather than trusting it — the "believe git over a stale stamp" branch — and a(DIRTY)build corresponds to no commit, whichRELEASING.mdsays must never run against live funds. Lint, Type-check, Test and Build all passed; nothing was tagged and nothing was published.The fix
uv lock. Seven lines, one per workspace member:No third-party dependency resolution moved — the diff is 7 insertions, 7 deletions.
Verified by reproducing the CI condition
With the lock committed,
uv syncnow leaves the working tree clean. That is the precise condition that failed: the release stamps from a checkout that has just been synced, souv syncleaving anything modified is what makes the artifact unreleasable.Follow-up worth considering
The lockfile is only checked implicitly, by the dirty-tree guard three steps later, and the error it produces ("artifact reports a dirty tree") does not name the cause. A
uv lock --checkimmediately after checkout would fail in seconds with "the lockfile is out of date" instead of failing after Build with a message that sends you looking at the stamp. Happy to open that as a separate PR.🤖 Generated with Claude Code