chore(deps): bump go.opentelemetry.io/otel from 1.35.0 to 1.36.0#9
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
chore(deps): bump go.opentelemetry.io/otel from 1.35.0 to 1.36.0#9dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/go_modules/go.opentelemetry.io/otel-1.36.0
branch
2 times, most recently
from
b60df34 to
cf4ce55
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/go.opentelemetry.io/otel-1.36.0
branch
3 times, most recently
from
c129a24 to
74b4cf5
Compare
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.35.0 to 1.36.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.35.0...v1.36.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-version: 1.36.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/go.opentelemetry.io/otel-1.36.0
branch
from
74b4cf5 to
70c3625
Compare
Contributor
Author
|
Superseded by #21. |
dependabot
bot
deleted the
dependabot/go_modules/go.opentelemetry.io/otel-1.36.0
branch
CodeMonkeyCybersecurity
pushed a commit
that referenced
this pull request
Nov 7, 2025
…rial analysis Implemented critical fixes identified in comprehensive security review: P0 FIXES (BREAKING - Security Critical): 1. RLS Policy Silent Failure Fixed (database.go:178-280) - REMOVED 'true' parameter from current_setting() in all RLS policies - WHY: With 'true', missing app.current_team_id returned NULL (silent failure) - NOW: Missing app.current_team_id causes ERROR (fail loudly, not silently) - IMPACT: Prevents operational nightmare where users see no data - EVIDENCE: AWS Prescriptive Guidance, Permit.io RLS best practices 2. Superuser Bypass Verification Added (database.go:312-326) - Verifies bionic_application is NOT a superuser after hardening - WHY: Superusers bypass ALL RLS policies (makes security useless) - CHECK: SELECT rolsuper FROM pg_roles WHERE rolname = 'bionic_application' - FAILS if user is superuser with clear remediation steps - EVIDENCE: Bytebase "Common Postgres RLS Footguns" P1 FIXES (CRITICAL - Production Readiness): 3. team_id Index Verification Added (verification.go:306-349) - Checks 13 critical tables for team_id indexes - WHY: Missing indexes cause O(n) sequential scans on EVERY query - WARNS: Lists tables missing indexes with CREATE INDEX commands - IMPACT: Prevents major performance issues under load - EVIDENCE: AWS RLS recommendations (always index policy columns) 4. Thread-Safe Working Directory Handling (worker.go:34-63, 490-522) - REMOVED: os.Chdir() (process-wide, not thread-safe) - ADDED: execute.Options.WorkDir for docker compose (thread-safe) - WHY: os.Chdir() causes race conditions if called concurrently - BENEFIT: Safe for API exposure, concurrent executions 5. Directory Existence Validation (worker.go:40-61) - Checks /opt/moni exists before attempting operations - Checks docker-compose.yml exists with clear error messages - WHY: Prevents confusing errors, provides remediation steps - UX: "Run 'eos create moni' first to install Moni" 6. CRITICAL Application Integration Warning (database.go:328-352) - Loud, clear warning that app MUST set app.current_team_id - Explains impact: queries will ERROR without this - Shows example code: SET app.current_team_id = <team_id> - WHY: Without this, RLS blocks everything (intentional fail-closed) P2 FIXES (Important - Pattern Compliance): 7. README.md Created (pkg/moni/README.md) - 581 lines - REQUIRED: CLAUDE.md P0 Rule #9 (README in each directory) - Documents architecture, security, usage, troubleshooting - Includes security checklist, best practices, references - Comprehensive guide for maintenance and operations SECURITY IMPROVEMENTS: RLS Policies Now Fail Loudly: Before: app.current_team_id missing -> returns NULL -> user sees nothing After: app.current_team_id missing -> ERROR: unrecognized parameter Superuser Check: Before: No verification - RLS could be silently bypassed After: Explicit check - fails with clear error if superuser detected Performance Monitoring: Before: No index verification - silent performance degradation After: Warns about missing indexes with remediation SQL EVIDENCE-BASED: - PostgreSQL 2024/2025 RLS best practices (AWS, Crunchy Data, Permit.io) - Docker PostgreSQL SSL patterns (Red Gate, PostgreSQL docs) - Multi-tenant security patterns (Picus Security, Bytebase) FILES CHANGED: - pkg/moni/database.go: RLS policy fix + superuser check + warnings - pkg/moni/verification.go: team_id index verification - pkg/moni/worker.go: Thread-safe WorkDir + directory checks - pkg/moni/README.md: Comprehensive documentation (NEW) TESTING RECOMMENDED: 1. Verify RLS fails without app.current_team_id set 2. Verify superuser check catches misconfiguration 3. Run --verify-rls to check index status 4. Test concurrent --init calls (thread-safety) All fixes follow Eos patterns (AIE, structured logging, RuntimeContext). Zero breaking changes to public API.
CodeMonkeyCybersecurity
pushed a commit
that referenced
this pull request
Nov 7, 2025
Implements three critical fixes for RLS security: **Issue #8 (P0): RLS Policies Not Idempotent** - Added DROP POLICY IF EXISTS before each CREATE POLICY - Enables safe re-running of --init without failures - Files: pkg/moni/database.go (15 policies updated) **Issue #9 (P1): RLS Breaking Change Without Warning** - Added interactive confirmation before enabling RLS - Clear warning about application code requirements - Added --force flag to skip confirmation (CI/CD) - Files: pkg/moni/database.go, pkg/moni/types.go, cmd/update/moni.go **Issue #11 (P1): Superuser Check Only Warns** - Changed from logger.Warn to return error on query failure - Provides clear remediation steps - Prevents deploying RLS without verification - Files: pkg/moni/database.go **Changes:** - pkg/moni/types.go: Added Force bool to WorkerConfig - pkg/moni/database.go: - Updated EnableRowLevelSecurity signature to accept config - Added interaction.PromptYesNoSafe for breaking change confirmation - Added DROP POLICY IF EXISTS for all 15 RLS policies - Changed superuser verification to fail hard on error - pkg/moni/worker.go: Updated EnableRowLevelSecurity call to pass config - cmd/update/moni.go: Added --force flag and wired to WorkerConfig **Usage:** sudo eos update moni --init # Interactive (prompts) sudo eos update moni --init --force # Automated (skips confirmation) **Breaking Change:** RLS enablement now requires explicit confirmation unless --force is provided. This ensures operators understand the application code changes required (setting app.current_team_id). Refs: Second adversarial analysis - Issues #8, #9, #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps go.opentelemetry.io/otel from 1.35.0 to 1.36.0.
Changelog
Sourced from go.opentelemetry.io/otel's changelog.
Commits
a85ae98Release v1.36.0/v0.58.0/v0.12.0 (#6793)3f85c35logtest: add Desc (#6796)d2fff76chore(deps): update module github.com/uudashr/iface to v1.4.0 (#6798)2d4c9dcAddsemconv/v1.32.0(#6782)fe523bdlogtest: add Transform (#6794)e578799fix(deps): update googleapis to 55703ea (#6795)af189e5chore(deps): update module github.com/golangci/misspell to v0.7.0 (#6792)836a2cechore(deps): update module github.com/alecthomas/chroma/v2 to v2.18.0 (#6790)93f8f13chore(deps): update github/codeql-action action to v3.28.18 (#6789)1556ff2chore(deps): update codecov/codecov-action action to v5.4.3 (#6785)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)