SAN-2944-email-admins

[Nathan219]

This PR adds the SendGrid api and the ability for the team-invitations route to send emails to potential users

Reviewers*

• @bkendall
• @podviaznikov

[cflynn07]

add jsdoc block comment

[rsandor]

Move this to devops-scripts ansible variables?

[Nathan219]

Could you explain?

[podviaznikov]

do we have this email address setup?

[Nathan219]

Sendgrid uses this as the alias of the sender

[podviaznikov]

I mean is this real email address. Do we have it registered on our mail server? If I write to this email address will it bounced to accepted

[bkendall]

I agree with @podviaznikov - it should be a valid address

[podviaznikov]

minor questions/comments from me (non-blockers). But looks good: 👍

[bkendall]

👍

[bkendall]

I would actually ask you do log.fatal - you're gonna be crashing the process here, so it's fatal

[bkendall]

did we go to aggressive? you still want to throw an error in a then before this catch, otherwise, you'll never see that it didn't break

[bkendall]

that looks much better to me

[bkendall]

double check that all the sendgrid environment variables are in devops scrips that you need, and then marge away!

[Nathan219]

CodeNow/devops-scripts#219

[cflynn07]

SendGridModel.prototype.inviteAdmin - > inviteAdmin

[cflynn07]

@Nathan219 for all your trace/error/warn logs after your function's initial info log, use just the prototype property name for the prefix to your msg field instead of the full prototype path.

ex:

Class.prototype.someMethod = function () {
  log.info({}, 'Class.prototype.someMethod');
  // do stuff
  log.trace({}, 'someMethod stuff happened')
}

https://github.com/CodeNow/devops-scripts/wiki/Guide-to-Using-Log-Levels

[cflynn07]

LGTM!