Add more logging in the autofork route#1251
Conversation
There was a problem hiding this comment.
forkMasterInstance -> Runnable.prototype.forkMasterInstance
There was a problem hiding this comment.
You and Casey seem to have a difference in opinion:
#1192 (comment)
There was a problem hiding this comment.
I have no rebuttal for that...
pretty solid commit message, that. 😉 |
bkendall
force-pushed
the
SAN-3170-logging
branch
from
4a89d20 to
0d38f6e
Compare
There was a problem hiding this comment.
make this logData. define it above.
There was a problem hiding this comment.
this normally goes at the top of the function: line 105
There was a problem hiding this comment.
well, since body isn't defined until well into the function, it's not going to be moved.
There was a problem hiding this comment.
well tx: true is defined at the top. In the places we use logData, I have only seen it defined at the top of the function. consistency is good ;)
Add more logging in the autofork route
3 participants
There isn't much here to log errors! We need some
rebase to one commit