Refactor fetch instance resource from API for error message generation by cflynn07 · Pull Request #8 · CodeNow/detention

cflynn07 · 2015-11-26T07:25:18Z

Refactor to fetch instance object directly from API for error display information generation.
Co-PR: CodeNow/navi#94

Review:

anandkumarpatel · 2015-11-30T03:31:17Z

Let's use Bunyan here. Also error cat create and report error and exit on cb

anandkumarpatel · 2015-12-02T23:46:59Z

move this above app.login, was a bug before, if listen error sync it will not get called.

also where is onError ?!

ahh nm, git diff messed me up

Was confused by what you thought you were seeing....

anandkumarpatel · 2015-12-02T23:52:08Z

nothing here?

remove unless you plan on adding something in the near future

I left it because yeah, I imagine it wont be long at all until I add something.

Nathan219 · 2015-12-03T02:20:18Z

if ports is undefined here, it causes an exception

Nathan219 · 2015-12-03T23:26:24Z

use req.instance.getBranchName() here

done
4c6656c

Nathan219 · 2015-12-04T19:20:03Z

This is null, which makes the links (view logs, go to container) not work

Did you see this? #8 (comment)

That's weird that the comment wasn't on the full change...

Nathan219 · 2015-12-05T01:29:52Z

LGTM

Refactor fetch instance resource from API for error message generation

cflynn07 added 9 commits November 26, 2015 08:56

Add runnable-api-client as dependency

4c9bcd8

Add npm dependencies and logic for super-user client

9e50eb7

Add logging utility to project

74837e6

Add npm dependencies for testing

2bc920d

Seed test files and package script

af96a83

Add sinon to project dependencies

f2555a7

Add super user login precondition to server listen

5e5c9c1

Fetch instance from API middleware

e8c3e28

Log module return child log instance

ab191aa

cflynn07 deployed to runnable November 26, 2015 07:26 Active

Add trace log

db767af

cflynn07 deployed to runnable November 26, 2015 07:33 Active

Add start check for required ENV keys

ab64255

cflynn07 deployed to runnable November 26, 2015 07:37 Active

cflynn07 added 2 commits November 26, 2015 17:07

Add error page generation logic for instance status

b140690

Fix jshint error

c815c1d

cflynn07 deployed to runnable November 26, 2015 10:06 Active

cflynn07 changed the title ~~Refactor detention~~ Refactor fetch instance resource from API for error message generation Nov 28, 2015

Add error-cat dep to project and use with invalid request params

5e78b79

cflynn07 deployed to runnable November 30, 2015 03:15 Active

cflynn07 mentioned this pull request Nov 30, 2015

Ansible deployment changes for refactored detention CodeNow/devops-scripts#217

Merged

Invoke next with error if instance not found

0b64376

anandkumarpatel reviewed Nov 30, 2015
View reviewed changes

Comment thread bin/www Outdated

Copy link
Copy Markdown

Contributor

anandkumarpatel Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use Bunyan here. Also error cat create and report error and exit on cb

cflynn07 deployed to runnable November 30, 2015 03:31 Active

Use expressjs view engine local vars

8b78d96

cflynn07 deployed to runnable November 30, 2015 03:42 Active

Use assign to extend app.locals

2d42b54

cflynn07 deployed to runnable November 30, 2015 06:20 Active

Reorganize functions into private module properties for unit tests

8972fe4

cflynn07 deployed to runnable November 30, 2015 07:09 Active

anandkumarpatel reviewed Dec 2, 2015
View reviewed changes

cflynn07 deployed to runnable December 2, 2015 23:50 Active

anandkumarpatel reviewed Dec 2, 2015
View reviewed changes

cflynn07 added 2 commits December 3, 2015 07:56

Add rollbar report wait process exit

9591b25

Remove serializers put extension

83a6ad7

cflynn07 deployed to runnable December 3, 2015 00:01 Active

Fix undefined reference

ae7769f

cflynn07 deployed to runnable December 3, 2015 00:14 Active

Nathan219 reviewed Dec 3, 2015
View reviewed changes

Comment thread app.js Outdated

Copy link
Copy Markdown

Member

Nathan219 Dec 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ports is undefined here, it causes an exception

Fix typo in app module

181f42e

cflynn07 deployed to runnable December 3, 2015 08:33 Active

Add port exception prevent logic

cf117d1

cflynn07 deployed to runnable December 3, 2015 08:35 Active

Nathan219 reviewed Dec 3, 2015
View reviewed changes

Refactor code to use instance.getBranchName()

4c6656c

cflynn07 deployed to runnable December 4, 2015 00:54 Active

Nathan219 reviewed Dec 4, 2015
View reviewed changes

Change format of title in README

1606b54

cflynn07 deployed to runnable December 5, 2015 01:14 Active

Temporarily hide links until bug resolved

326844a

cflynn07 deployed to runnable December 5, 2015 01:15 Active

Nathan219 added a commit that referenced this pull request Dec 5, 2015

Merge pull request #8 from CodeNow/SAN-3006-refactor-detention

408f594

Refactor fetch instance resource from API for error message generation

Nathan219 merged commit 408f594 into master Dec 5, 2015

Nathan219 deleted the SAN-3006-refactor-detention branch December 5, 2015 01:30

Conversation

cflynn07 commented Nov 26, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nathan219 commented Dec 5, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants