Skip to content

Ansible deployment changes for refactored detention#217

Merged
und1sk0 merged 5 commits intomasterfrom
SAN-3006-refactor-detention
Dec 2, 2015
Merged

Ansible deployment changes for refactored detention#217
und1sk0 merged 5 commits intomasterfrom
SAN-3006-refactor-detention

Conversation

@cflynn07
Copy link
Copy Markdown
Contributor

Comment thread ansible/group_vars/all.yml Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you move this here? there is a github token per env.

Comment thread ansible/beta-hosts/variables Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break api because api also needs this key. it needs to be just under [beta:vars]. so just delete this line and remove the new line above it and it will work.

@und1sk0
Copy link
Copy Markdown
Contributor

und1sk0 commented Dec 2, 2015

Nothing leaps out as problematic to me, approving this merge.

und1sk0 added a commit that referenced this pull request Dec 2, 2015
Ansible deployment changes for refactored detention
@und1sk0 und1sk0 merged commit a167ba2 into master Dec 2, 2015
@und1sk0 und1sk0 deleted the SAN-3006-refactor-detention branch December 2, 2015 23:31
@anandkumarpatel
Copy link
Copy Markdown

@und1sk0 @cflynn07 this change will also need to be made to gamma and delta configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants