Skip to content

Khronos Swarm#412

Merged
anandkumarpatel merged 5 commits intomasterfrom
SAN-3094-khronos-swarm
Apr 6, 2016
Merged

Khronos Swarm#412
anandkumarpatel merged 5 commits intomasterfrom
SAN-3094-khronos-swarm

Conversation

@bkendall
Copy link
Copy Markdown
Contributor

@bkendall bkendall commented Apr 5, 2016

  • khronos now talks with SWARM!
  • fixed missing env vars for epsilon

Reviewers

Tests

Test any modifications on one of our environments.

Deployment (post-merge)

Ensure that all environments have the given changes.

  • deployed to epsilon
  • deployed to gamma
  • deployed to delta

@bkendall bkendall added the review label Apr 5, 2016
Comment thread ansible/epsilon-hosts/variables Outdated
eru_github_secret=74a23ee56486d57b14f292283cb04625f600917c

[khronos:vars]
intercom_api_key=037d14f2758eac144de1d2657b2ef9a4f26aef1a
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we actually put these into /all where things were required but not used.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must've missed these because I was testing intercom ON gamma at the time.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where you're going with this. I'm following the pattern that was set forth already. It was broken for epsilon; this is the fix given the current setup.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, hey looks like we should be using | default() didn't know about that.

@und1sk0
Copy link
Copy Markdown
Contributor

und1sk0 commented Apr 5, 2016

I'll give @Myztiq the final yay/nay on this.

@Myztiq
Copy link
Copy Markdown

Myztiq commented Apr 5, 2016

Sorry, for starting a shitty pattern. I think we should clean it up, unsure if it's worth it to do right now. I had no clue about how ansible does defaulting.

Comment thread ansible/group_vars/all.yml Outdated
# khronos
rollbar_khronos_token: 5a140828cce14410812d34a3ef936f25
khronos_canary_logs_instance_id: undefined
intercom_api_key: undefined
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea... lets not do this use default below

@anandkumarpatel anandkumarpatel merged commit e9e7d11 into master Apr 6, 2016
@anandkumarpatel anandkumarpatel deleted the SAN-3094-khronos-swarm branch April 6, 2016 21:35
@anandkumarpatel anandkumarpatel restored the SAN-3094-khronos-swarm branch April 11, 2016 20:11
@anandkumarpatel anandkumarpatel deleted the SAN-3094-khronos-swarm branch January 2, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants