Khronos Swarm#412
Conversation
| eru_github_secret=74a23ee56486d57b14f292283cb04625f600917c | ||
|
|
||
| [khronos:vars] | ||
| intercom_api_key=037d14f2758eac144de1d2657b2ef9a4f26aef1a |
There was a problem hiding this comment.
IIRC we actually put these into /all where things were required but not used.
There was a problem hiding this comment.
I must've missed these because I was testing intercom ON gamma at the time.
There was a problem hiding this comment.
I don't know where you're going with this. I'm following the pattern that was set forth already. It was broken for epsilon; this is the fix given the current setup.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, hey looks like we should be using | default() didn't know about that.
|
I'll give @Myztiq the final yay/nay on this. |
|
Sorry, for starting a shitty pattern. I think we should clean it up, unsure if it's worth it to do right now. I had no clue about how ansible does defaulting. |
| # khronos | ||
| rollbar_khronos_token: 5a140828cce14410812d34a3ef936f25 | ||
| khronos_canary_logs_instance_id: undefined | ||
| intercom_api_key: undefined |
There was a problem hiding this comment.
yea... lets not do this use default below
Reviewers
Tests
Deployment (post-merge)