Replace Mavis with Swarm#60
Merged
anandkumarpatel merged 9 commits intomasterfrom Apr 6, 2016
Merged
Conversation
| @@ -1,8 +1,6 @@ | |||
| [ | |||
Member
There was a problem hiding this comment.
can you rename mavis folder too?
Member
|
sorry, couldn't find any problems with this PR. Looks great 👍 |
| } | ||
|
|
||
| Swarm.prototype.checkHostExists = function (host) { | ||
| if (host.indexOf('//') !== -1) { |
Contributor
There was a problem hiding this comment.
How often does this happen? I thought we use the same form of this everywhere
Contributor
Author
There was a problem hiding this comment.
it's really for backwards compatibility with the previous mavis task definitions. it's something we can change later, but it would require changing every task definition as well
Contributor
|
Some questions and requests for jsdoc. LGTM |
Contributor
|
+1 you have my checkmark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now Swarm is used for all the dock info...
Dependencies
CodeNow/devops-scripts#412
Reviewers
Tests