Prevent extendedTimeOut from overriding the timeOut #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty If intervalId != null then there’s a scheduled timeOut timer. If registeredDelay == true there’s a scheduled extendedTimeOut timer. The extendedTimeOut timer checks if intervalId == null before hiding the toast, if it isn’t, the toast isn’t hidden. The timeOut timer checks if registeredDelayed == true before hiding the toast, if it isn’t, the toast isn’t hidden. The stickAround function no longer clears the previous timeout, but the timeout checks for :hover before hiding.
|
👍 |
|
@tonyjmnz are you going to resolve conflicts and merge this fix? |
Author
|
I'd like to see it merged, but that's up to the project owners. |
Member
|
We've been pretty busy lately and working towards v3. So it might be a bit til we can get bandwidth to test these. But what would help is you adding tests. Any change we make has to have a pass and fail test for it to keep the library's integrity |
Author
|
Sounds reasonable. I'll try to add them soon. |
Member
|
@tonyjmnz - any update here? |
Member
|
No update; PR is against incorrect branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to solve #314.
It seems to be working properly for me, although I have to admit that I haven't tested it for all the different options.
Changes:
intervalId != nullthen there’s a scheduledtimeOutinterval.registeredDelay == truethere’s a scheduledextendedTimeOutinterval.extendedTimeOutinterval checks ifintervalId == nullbefore hiding the toast, if it isn’t, the toast isn’t hidden.timeOuttimer checks ifregisteredDelayed == truebefore hiding the toast, if it isn’t, the toast isn’t hidden. (prevents the formertimeOutinterval to override aextendedTimeOutinterval)stickAroundfunction no longer clears thetimeOutinterval, but the function checks for:hoverbefore hiding.New behaviour:
The toast isn't hidden if the added
extendedTimeOuttimer ends before the formertimeOuttimer.