Skip to content

Add ability to specify default toast titles per toast type #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbrewerton wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add ability to specify default toast titles per toast type #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60f4bc6
Add a default title option feature for toast messages.
mbrewerton Oct 26, 2016
3b4459d
Added unit tests covering default titles
mbrewerton Oct 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions tests/unit/toastr-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,67 @@
$toast.remove();
clearContainerChildren();
});

module('default titles', {
teardown: function() {
toastr.options.successTitle = undefined,
toastr.options.errorTitle = undefined,
toastr.options.warningTitle = undefined,
toastr.options.infoTitle = undefined
}
});
test('success - has default title', 2, function() {
var title = 'Success';
//Arrange
toastr.options.successTitle = title;
//Act
var $toast = toastr.success('My success toast');
//Assert
equal($toast.find('div.toast-title').length, 1, 'Has a default title');
equal($toast.find('div.toast-title').html(), title, 'Title matches our default title')
//Teardown
$toast.remove();
clearContainerChildren();
});
test('error - has default title', 2, function() {
var title = 'Error';
//Arrange
toastr.options.errorTitle = title;
//Act
var $toast = toastr.error('My error toast');
//Assert
equal($toast.find('div.toast-title').length, 1, 'Has a default title');
equal($toast.find('div.toast-title').html(), title, 'Title matches our default title')
//Teardown
$toast.remove();
clearContainerChildren();
});
test('warning - has default title', 2, function() {
var title = 'warning';
//Arrange
toastr.options.warningTitle = title;
//Act
var $toast = toastr.warning('My warning toast');
//Assert
equal($toast.find('div.toast-title').length, 1, 'Has a default title');
equal($toast.find('div.toast-title').html(), title, 'Title matches our default title')
//Teardown
$toast.remove();
clearContainerChildren();
});
test('info - has default title', 2, function() {
var title = 'info';
//Arrange
toastr.options.infoTitle = title;
//Act
var $toast = toastr.info('My info toast');
//Assert
equal($toast.find('div.toast-title').length, 1, 'Has a default title');
equal($toast.find('div.toast-title').html(), title, 'Title matches our default title')
//Teardown
$toast.remove();
clearContainerChildren();
});


module('escape html', {
Expand Down
13 changes: 8 additions & 5 deletions toastr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
iconClass: getOptions().iconClasses.error,
message: message,
optionsOverride: optionsOverride,
title: title
title: title || getOptions().errorTitle
});
}

Expand All @@ -71,7 +71,7 @@
iconClass: getOptions().iconClasses.info,
message: message,
optionsOverride: optionsOverride,
title: title
title: title || getOptions().infoTitle
});
}

Expand All @@ -85,7 +85,7 @@
iconClass: getOptions().iconClasses.success,
message: message,
optionsOverride: optionsOverride,
title: title
title: title || getOptions().successTitle
});
}

Expand All @@ -95,7 +95,7 @@
iconClass: getOptions().iconClasses.warning,
message: message,
optionsOverride: optionsOverride,
title: title
title: title || getOptions().warningTitle
});
}

Expand Down Expand Up @@ -169,7 +169,10 @@
closeDuration: false,
closeEasing: false,
closeOnHover: true,

successTitle: undefined,
errorTitle: undefined,
warningTitle: undefined,
infoTitle: undefined,
extendedTimeOut: 1000,
iconClasses: {
error: 'toast-error',
Expand Down