Added variables to toastr sass #538
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo
At the moment, in the readme, headers were missing a space after the hashtags, this edit adds the required missing space, so the hastags are rendered as headings instead
Fix headers in readme
Update README.md
Add link to Ruby on Rails gem
…e namespaced and contextual
Author
|
Pulled 2.1.4 into the pull request |
|
I came here to see if this was implemented. I think its a really good idea but should you also add |
Author
|
Probably. I think there was a reason I didn't but it was probably wrong. Either way it has been over a year since I emailed @TimFerrell and he said he'd accept it, didn't, and then ignored a follow up email maybe 6 months later. |
|
That's a shame - well thanks for at least giving it a go. It seems like its high time for a modern alternative to this library to come along (unless there is one already). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sass was a bit limited by how it couldn't use variables to change the colours. so I converted the less file to sass and split the variables out into contextual variables. I did the same in less too with the variables in case it was wanted.