Skip to content

Fix typo in welcome.yml for repo_token#18

Merged
rezwana-karim merged 2 commits into
mainfrom
rezwana-karim-patch-1
Oct 20, 2025
Merged

Fix typo in welcome.yml for repo_token#18
rezwana-karim merged 2 commits into
mainfrom
rezwana-karim-patch-1

Conversation

@rezwana-karim

Copy link
Copy Markdown
Collaborator

This pull request makes a minor update to the workflow configuration in .github/workflows/welcome.yml. The change corrects the input parameter name for the actions/first-interaction GitHub Action from repo-token to repo_token.

Description

Why

Fixes #
Related to #

What

Type of Change

Please check the relevant option(s):

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Style/UI change
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • ✅ Test addition or update
  • 🔧 Configuration change
  • 🏗️ Infrastructure change

Checklist

Please ensure your PR meets the following requirements:

Code Quality

  • Code follows the project's TypeScript and code style guidelines
  • Code is properly formatted (ran npm run format)
  • Code passes linting (ran npm run lint)
  • TypeScript compiles without errors (ran npm run type-check)
  • No any types used (except for documented third-party library interfaces)
  • File size limits respected (max 300 lines per file, 50 lines per function)

Testing

  • All existing tests pass (ran npm run test)
  • New tests have been added for new features or bug fixes
  • Test coverage meets requirements:
    • Business logic: minimum 80% coverage
    • Utility functions: 100% coverage
    • API routes: integration tests added
    • Critical paths: E2E tests added (if applicable)
  • Tests follow AAA pattern (Arrange, Act, Assert)

Security & Best Practices

  • Authentication checks are in place for protected routes
  • Multi-tenant isolation is enforced (storeId filtering)
  • Input validation is implemented using Zod schemas
  • No secrets or sensitive data in code (using environment variables)
  • SQL injection prevention (using Prisma, no raw SQL)
  • XSS prevention (proper input sanitization)

Documentation

  • Documentation has been updated (if applicable)
  • JSDoc comments added for complex functions
  • API documentation updated (if API changes were made)
  • README.md updated (if needed)
  • Specification documents updated (if architectural changes were made)

Database (if applicable)

  • Database migration created (if schema changes were made)
  • Migration tested on local database
  • Seed data updated (if needed)
  • Indexes added for new query patterns
  • Soft delete pattern followed for user-facing data

Accessibility (if UI changes were made)

  • Meets WCAG 2.1 Level AA standards
  • Keyboard navigation works properly
  • ARIA labels added where necessary
  • Color contrast ratios meet requirements (≥ 4.5:1)
  • Focus indicators are visible
  • Alt text provided for images
  • Tested with screen reader (if major UI changes)

Performance (if applicable)

  • Page load time within budget (< 2.0s LCP desktop, < 2.5s mobile)
  • API response time within budget (< 500ms p95)
  • Database queries optimized (no N+1 queries)
  • Images optimized (using Next.js Image component)
  • Bundle size within limits (< 200KB initial load)

Build & Deployment

  • Build succeeds locally (ran npm run build)
  • No console errors or warnings
  • Environment variables documented (if new ones added)
  • Works in both development and production modes

Screenshots (if applicable)

Before

After

Additional Context

Reviewer Notes


By submitting this pull request, I confirm that:

  • I have read and agree to follow the Code of Conduct
  • I have read the Contributing Guidelines
  • My contribution is original work or properly attributed
  • I agree to license my contribution under the project's MIT License

Copilot AI review requested due to automatic review settings October 20, 2025 19:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a parameter name typo in the GitHub Actions welcome workflow configuration. The actions/first-interaction@v3 action requires the parameter name repo_token (with underscore), but the workflow was incorrectly using repo-token (with hyphen).

Key Changes:

  • Fixed the parameter name from repo-token to repo_token in the welcome workflow

@github-actions

Copy link
Copy Markdown

👋 Thanks for opening your first pull request in StormCom!

A maintainer will review your PR soon. Please make sure:

  • Your PR follows our
    Contributing Guidelines
  • All CI checks pass
  • You've added appropriate tests
  • Documentation has been updated (if needed)

We appreciate your contribution to making StormCom better! 🚀

@rezwana-karim
rezwana-karim requested a review from Copilot October 20, 2025 19:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@rezwana-karim
rezwana-karim merged commit edffd9f into main Oct 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants