Pr 20 - #21
Merged
Merged
Conversation
Add multiple accessibility fixes and align Android launch visuals: register semantic actions for bottom nav and center FAB so TalkBack/UiAutomator can activate tabs; add descriptive Semantics/ExcludeSemantics wrappers for Add Pet wizard (progress bar + animal options), pet profile (stats, header buttons, Add Pet avatar), home/marketplace badges and promo banner to prevent duplicated or missing screen-reader output; enhance Pet Care progress semantics and ProgressRing labels. Also replace the white launch background with a dark splash color (#0F0E0C) via a new colors.xml and update styles.xml to use the dark launch theme to eliminate the white flash. These changes improve accessibility, automated testing reliability, and brand-consistent launch visuals.
…m-Hub/petsphere into cursor-review-implement
Add .gemini/settings.json to register an mcpServer 'appium-mcp' that runs 'npx -y appium-mcp@latest'. Update android/gradle.properties to enable the Windows Android Studio JBR as org.gradle.java.home (uncommented) and comment out the Linux java-21-openjdk entry so the build uses the intended JDK/toolchain.
## Summary Draft PR for branch \cursor-review-implement\ into \main\. ### Included work (existing commits only) - Audits, integration test harness, bootstrap, theme switching, and related project updates. - Attachments flow and chat UX, pet selectors, achievements/badges in settings, search fixes, and other UI/controller changes from the review pass. ### Notes - Opened as **draft** for review; no additional commits were made for this PR. ### How to verify - \ lutter analyze\ - Run on Android emulator and spot-check: Home, Search, Discovery, Pet Care, Chat, Settings, notifications. Made with [Cursor](https://cursor.com)
…ed imports in adoption center screen
There was a problem hiding this comment.
Pull request overview
This PR primarily implements UI accessibility improvements (Semantics/Tooltips) across multiple Flutter screens, adds some Marketplace UI enhancements (promo banner, extra categories, order-history entry point), and tweaks Android splash theming resources to avoid a white flash at launch.
Changes:
- Added/updated
Semantics,Tooltip, andExcludeSemanticswrappers to improve screen-reader output for navigation, badges, profile stats, progress indicators, and action icons. - Updated Marketplace UI with an order history button, a new promo banner, and additional category chips; removed unused widgets/imports.
- Adjusted Android launch theme/background resources for a consistently dark splash.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/views/pet_profile_screen.dart | Adds labeled Settings/Sign out actions and improves semantics for “Add pet” and stat readouts. |
| lib/views/pet_care_screen.dart | Adds semantics for checklist progress and progress ring announcements. |
| lib/views/marketplace_screen.dart | Adds Order History button, promo banner semantics, and more categories; removes unused code. |
| lib/views/main_layout.dart | Adds explicit semantics labels/hints/actions to bottom navigation and center FAB. |
| lib/views/home_screen.dart | Excludes notification/message badge counts from semantics to avoid double-reading. |
| lib/views/adoption_center_screen.dart | Removes unused imports. |
| lib/views/add_pet_screen.dart | Adds semantics for step progress and animal-type selection tiles. |
| lib/repositories/feed_repository.dart | Updates post payload construction (currently introduces a Dart syntax error). |
| docs/plan/cursor_ui_ux_audit_of_flutter_app.md | Adds an exported UI/UX audit document. |
| android/gradle.properties | Changes Gradle JDK configuration (currently hardcodes a Windows-specific JDK path). |
| android/app/src/main/res/values/styles.xml | Updates launch/normal themes to use a dark theme. |
| android/app/src/main/res/values/colors.xml | Adds splashBackground color resource (comment contains an encoding artifact). |
| android/app/src/main/res/drawable/launch_background.xml | Points splash background at @color/splashBackground. |
| .gemini/settings.json | Adds Gemini MCP server settings for appium-mcp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+272
to
+274
| 'location': ?location, | ||
| 'tagged_pet_ids': ?taggedPetIds, | ||
| 'tagged_pet_names': ?taggedPetNames, |
Comment on lines
+4
to
6
| org.gradle.java.home=C:\\Program Files\\Android\\Android Studio\\jbr | ||
| # Enable parallel build to speed up the build process | ||
| org.gradle.parallel=true |
Comment on lines
+3
to
+4
| <!-- PetSphere dark surface � matches app theme background (#0F0E0C) --> | ||
| <color name="splashBackground">#0F0E0C</color> |
…pdate imports in pet profile screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.