Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

Update exercises#4

Merged
ChrisOwen101 merged 1 commit into
mainfrom
update-exercises
Apr 18, 2021
Merged

Update exercises#4
ChrisOwen101 merged 1 commit into
mainfrom
update-exercises

Conversation

@bonboh

@bonboh bonboh commented Apr 16, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Updated exercises

@bonboh bonboh left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ChrisOwen101, I went through these exercises to create solutions for them and have got a few tweaks to make it better. Do they seem okay?

‘The zoo is open every day of the year and features three major biomes: the Tropic Zone, Temperate Territory, and the Polar Circle. From tropical birds, to snow leopards, grizzly bears, and one of the nation’s largest colonies of Antarctic penguins, there are animals to enjoy in every season.’

## 2) Bears:
Most of the text on the page is very close together. Increase the amount of space of the text so that there's more breathing space.

@bonboh bonboh Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved from 2) Bears. It seems like the text that's close together isn't an issue with paragraph margin, but with text line height. I've updated the task to try and get the trainee to update line-height to increase the text spacing.


Make the first paragraph have a larger font size.

Again, the purple headings are hard to read on dark backgrounds, change them to a lighter colour.

@bonboh bonboh Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just changed the headings on line 37, Change the background colour to #483C46, the section titles to #F4743B, so the headings aren't purple anymore

Add another news item with the title with today's date, and the title of ‘Which big cat are you?’

## 6) Membership
## 6) Learning

@bonboh bonboh Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Learning section was switched with Membership below as it comes first in the source code. Having it in a different order confused me when going through the tasks


The cards are stacked on top of each other which looks like a poor use of space. Change these so that they display horizontally across the screen.

Change each of the ‘Find out more’ links to a button, each one should have a different colour.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like this task is to change the a to a button, which shouldn't be done if the element links to another document.

@bonboh bonboh requested a review from ChrisOwen101 April 16, 2021 15:34
@ChrisOwen101 ChrisOwen101 merged commit 3dffdfe into main Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants