This repository was archived by the owner on Jan 14, 2024. It is now read-only.
North West 4- Bimbola Lasisi- Html/Css -Week1#55
Closed
blasisi wants to merge 1 commit into
Closed
Conversation
Created html and css blog website Include the following element : Header, articles section , Article and Footer sections using semantic html tags and first-child pseudo-class.
nax2uk
reviewed
May 24, 2021
nax2uk
left a comment
nax2uk
left a comment
There was a problem hiding this comment.
Well done on completing this assignment! 🎉
Please see my separate comments and it would be good if you could improve on it.
Let me know if you have any questions. 🙂
Comment on lines
+31
to
+47
| <article> | ||
| <header> | ||
| <h2> | ||
| What is Lorem Ipsum? | ||
| </h2> | ||
| <img | ||
| src="https://dvg5hr78c8hf1.cloudfront.net/2016/06/17/13/45/01/cc2fac88-2f81-4cc5-9ec9-334042781fd0/1*OsjnQFK1i6CkjXQmTErAtw.jpeg" | ||
| alt=" JavaScript image"> | ||
| <p> | ||
| Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the | ||
| industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and | ||
| scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into | ||
| electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of | ||
| Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like | ||
| Aldus PageMaker including versions of Lorem Ipsum. | ||
| </p> | ||
| </article> |
There was a problem hiding this comment.
Well done you have added a title using the <h2> tag. 👍🏽
Please see below for improvements:
- You are missing a closing tag
</header>in between the<articles></articles>block. Actually, you have instead put the closing</header>tag outside the<articles></articles>block - The task also requires you to include a
<summary></summary>block within the<articles></articles>block. Please can you add that to your code.
Author
There was a problem hiding this comment.
Thank you , I will work on it Asap
Comment on lines
+50
to
+64
| <article> | ||
| <header> | ||
| <h2> | ||
| Why do we use it? | ||
| </h2> | ||
| <img src="https://www.tutorialrepublic.com/lib/images/javascript-illustration.png" alt=" JavaScript image"> | ||
| <p> | ||
| It is a long established fact that a reader will be distracted by the readable content of a page when | ||
| looking at its layout. The point of using Lorem Ipsum is that it has a more-or-less normal distribution of | ||
| letters, as opposed to using 'Content here, content here', making it look like readable English. Many | ||
| desktop publishing packages and web page editors now use Lorem Ipsum as their default model text, and a | ||
| search for 'lorem ipsum' will uncover many web sites still in their infancy. Various versions have evolved | ||
| over the years, sometimes by accident, sometimes on purpose (injected humour and the like). | ||
| </p> | ||
| </article> |
There was a problem hiding this comment.
Well done you have added a title using the <h2> tag. 👍🏽
Please see below for improvements:
- You are missing a closing tag
</header>in between the<articles></articles>block. Actually, you have instead put the closing</header>tag outside the<articles></articles>block - The task also requires you to include a
<summary></summary>block within the<articles></articles>block. Please can you add that to your code.
Comment on lines
+67
to
+82
| <article> | ||
| <header> | ||
| <h2> | ||
| Where does it come from? | ||
| </h2> | ||
| <img src="https://cdn.educba.com/academy/wp-content/uploads/2019/03/introduction-to-javascript.png.webp" | ||
| alt=" An introduction to JavaScript image"> | ||
| <p> Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots in a piece of classical | ||
| Latin literature from 45 BC, making it over 2000 years old. Richard McClintock, a Latin professor at | ||
| Hampden-Sydney College in Virginia, looked up one of the more obscure Latin words, consectetur, from a Lorem | ||
| Ipsum passage, and going through the cites of the word in classical literature, discovered the undoubtable | ||
| source. Lorem Ipsum comes from sections 1.10.32 and 1.10.33 of "de Finibus Bonorum et Malorum" (The Extremes | ||
| of Good and Evil) by Cicero, written in 45 BC. This book is a treatise on the theory of ethics, very popular | ||
| during the Renaissance. The first line of Lorem Ipsum, "Lorem ipsum dolor sit amet..", comes from a line in | ||
| section 1.10.32.</p> | ||
| </article> |
There was a problem hiding this comment.
Please see previous two comments above regarding the closing </header> tag and <summary> tag and improve on this code. Thanks.
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created html and css blog website Include the following element : Header, articles section , Article and Footer sections using semantic html tags and first-child pseudo-class.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?
View rendered .github/pull_request_template.md