Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Manchester_5-Yousef Shaikhan-HTML/CSS(grid)-WEEK3#393

Open
youweb3 wants to merge 1 commit into
CodeYourFuture:masterfrom
youweb3:master
Open

Manchester_5-Yousef Shaikhan-HTML/CSS(grid)-WEEK3#393
youweb3 wants to merge 1 commit into
CodeYourFuture:masterfrom
youweb3:master

Conversation

@youweb3
Copy link
Copy Markdown

@youweb3 youweb3 commented Aug 12, 2022

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:Yousef Shaikhan
  • Your City:Manchester
  • Your Slack Name: Yousef shaikhan

Homework Details

  • Module:Grid
  • Week:3

Notes

  • What did you find easy?

  • What did you find hard? CSS grid hard for me.

  • What do you still not understand? CSS position and layout

  • Any other notes?

@SteveLeicester
Copy link
Copy Markdown

Hello Yousef,

Thank you for submitting a pull request with your homework.

It is good that you have used some semantic HTML to break your page into smaller pieces (boxes - do you remember the box model).

Some things to think about. It's nice to break up a page into a header, main and footer (inside the body). Don't confuse header tag with head tag (head tag does not display anything just hold information about the page)

<body>

<header>
</header>
<main>
</main>
<footer>
</footer>

</body>

So now just three things to think about how to arrange on your page (one above the other).

Then think about each of these things.

What about the header - a title and navigation perhaps? Use a navigation tag for navigation by the way.

Then you can look at the main. You have broken your main into smaller sections. This is a good approach. How do you want each section to be displayed - in a column for a mobile and across the page for a browser perhaps. CSS can do this work. This can be the tricky bit but a lot easier if you have divided you whole page into smaller boxes.

Keep up the good work though
Steve

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants