Skip to content

GLASGOW_CLASS_5_OMER_ALI_HTML_CSS_WEEK_2 #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Omer249a wants to merge 1 commit into from
Closed

GLASGOW_CLASS_5_OMER_ALI_HTML_CSS_WEEK_2 #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
205 changes: 205 additions & 0 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,209 @@ body {
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/

body {
font-family: "Roboto", sans-serif;
-webkit-font-smoothing: antialiased;
font-size: 16px;
Copy link
Copy Markdown
Contributor

@bonboh bonboh Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: 16px;

We should never override the browser font size setting, as this means if the user changes their browser setting font size to 24px then this website doesn't increase in size. Also, it's good practice to use relative units like % or rem for font-size instead of px so elements change proportionally when the user changes font size.

}
/* Header Section */
header {
display: flex;
justify-content: space-evenly;
align-items: center;
}
header img {
height: 2.4rem;
padding: 1rem 0 1rem 2rem;
}

/* Navigation Section */

nav ul {
display: flex;
justify-content: space-evenly;
list-style: none;
width: 34rem;
}

nav ul a {
text-decoration: none;
color: #9c9fa7;
}
Comment on lines +37 to +47
Copy link
Copy Markdown
Contributor

@bonboh bonboh Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nav ul {
display: flex;
justify-content: space-evenly;
list-style: none;
width: 34rem;
}
nav ul a {
text-decoration: none;
color: #9c9fa7;
}
nav ul {
display: flex;
justify-content: space-evenly;
list-style: none;
}
nav ul a {
text-decoration: none;
color: #9c9fa7;
padding: 1rem;
}

It's usually not a good idea to give an element a set width, because it makes it less flexible. Instead, we can remove the width and add padding to the a elements to add space between the links instead


nav ul a:hover {
Copy link
Copy Markdown
Contributor

@bonboh bonboh Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nav ul a:hover {
nav ul a:focus,
nav ul a:hover {

When adding hover, we should also add focus so that keyboard users get the same styling when using the Tab key to jump to the link

color: #ffe70e;
}
li:first-child a {
color: rgb(117, 114, 114);
font-weight: 500;
}

/* Main Content Section */
.hero {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
background-image: url("../img/first-background.jpg");
width: 73rem;
height: 76vh;
margin: 0 auto;
background-position-x: -202px;
background-position-y: -26px;
background-repeat: no-repeat;
}
.hero h1,
h2 {
Comment on lines +71 to +72
Copy link
Copy Markdown
Contributor

@bonboh bonboh Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.hero h1,
h2 {
.hero h1,
.hero h2 {

The second selector h2 will apply the style to all h2 elements on the page. We only want to update the h2 element in the hero section, so we should update the selector to .hero h2

color: white;
font-weight: 100;
margin: 0;
}
.hero h1 {
font-size: 3.5rem;
}
.hero h2 {
letter-spacing: 2px;
padding: 1rem 0 3.5rem 0;
}
.hero button {
background-color: #e0633a;
color: rgb(255, 255, 255);
padding: 0.8rem 1.2rem;
border-radius: 5%;
border: none;
}
/* Features Icon Section */
.features {
width: 44rem;
margin: 0 auto;
padding-top: 5rem;
box-shadow: 0px 1px 0px #eae5e5;
}
.features h2 {
color: black;
text-align: center;
font-weight: 300;
font-size: 1.8rem;
padding-bottom: 2rem;
}
.icon-container {
display: flex;
}
.icons {
padding: 0 2rem;
}
.icons p {
width: 11.5rem;
}
.features img {
width: 10rem;
height: 6rem;
}

/* Footer Section */
footer {
display: flex;
flex-direction: column;
align-items: center;
}
footer section {
display: flex;
}
footer img {
height: 1.6rem;
padding: 0.3rem 0;
border-radius: 100%;
}
footer h3 {
font-size: 1rem;
font-weight: 400;
}
footer small {
padding: 1rem;
color: #9c9fa7;
}

/* Media Queries */
@media screen and (max-width: 375px) {
main {
display: flex;
flex-direction: column;
}
header {
width: 100vh;
}
header nav ul {
overflow: hidden;
height:0;
}
header nav ul.open {
height: auto;
font-size: 1.8rem;
margin-top: 3rem;
display: flex;
flex-direction: column;
border-bottom: 1px solid grey;
border-top: 1px solid grey;
}
header nav ul li {
display: block;
width: 100%;
margin:0;
}
header nav ul li a {
display: block;
padding: 10px;
margin:0;
}
header img{
height: 3.4rem;
padding: 2rem 0 1rem 4rem;
}
.hero {
width: 46rem;
height: 116vh;

background-position: center;
}
.icon-container {
flex-direction: column;
align-items: center;
}
.features {
width: 46rem;
}
.features h2{
font-size: 3.6rem;
}
footer {
width: 50rem;
height: 4vh;
}
.icons img{
width: 21.7rem;
height: 7rem;
}
.icons p{
font-size: 2rem;
width: 21rem;
text-align: center;
}
.burger-nav {
display: block;
height: 40px;
width: 100%;
background: url("../img/menu-hamburger.svg") no-repeat 98% center;
background-size: 2.5rem;
cursor: pointer;
}
footer h3{
font-size: 1.2rem;
}
footer img{
height: 2.4rem;
}
footer small{
font-size: 1.2rem;
}
}
53 changes: 53 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,58 @@
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<!-- All the images you need are in the 'img' folder -->

<header>
<img src="img/karma-logo.svg" alt="Logo of the website" />
Copy link
Copy Markdown
Contributor

@bonboh bonboh Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="img/karma-logo.svg" alt="Logo of the website" />
<img src="img/karma-logo.svg" alt="Karma logo" />

We can make the alt description more descriptive

<nav>

<ul>
<li><a href="#">Meet Karma</a></li>
<li><a href="#">How it Works</a></li>
<li><a href="#">Store</a></li>
<li><a href="#">Blog</a></li>
<li><a href="#">Help</a></li>
<li><a href="#">Login</a></li>
</ul>
<a class="burger-nav" id="burger-btn"></a>

</nav>
</header>
<main>
<!-- Background will be added in css -->
<section class="hero">
<h1>Introducing Karma</h1>
<h2>Bring WiFi with you, everywhere you go.</h2>
<button>Learn More</button>
</section>
<section class="features">
<h2>Everyone needs a little Karma.</h2>
<section class="icon-container">
<section class="icons">
<img src="img/icon-devices.svg" alt="Image
of different internet devices" />
Comment on lines +45 to +46
Copy link
Copy Markdown
Contributor

@bonboh bonboh Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="img/icon-devices.svg" alt="Image
of different internet devices" />
<img src="img/icon-devices.svg" alt="Different internet devices" />

We don't need to put "Image" in the alt description as we already know it's an image. Same goes for the other alt descriptions below

<p>Internet for all devices</p>
</section>
<section class="icons">
<img src="img/icon-coffee.svg" alt="Image of a coffee cup" />
<p>Boost your productivity</p>
</section>
<section class="icons">
<img src="img/icon-refill.svg" alt="Gas refill tank image" />
<p>Pay as You Go</p>
</section>
</section>
</section>
</main>
<footer>
<h3>Join us on</h3>
<section>
<img src="img/twitter-icon.svg" alt="twitter icon"/>
<img src="img/facebook-icon.svg" alt="facebook icon" />
<img src="img/instagram-icon.svg" alt="instagram icon" />
</section>

<small>&copy; Karma Mobility, Inc.</small>
</footer>

</body>
</html>