ZA2-Riyaaz Singh - HTML-CSS-Module-Project - week-03#356
Conversation
Riyaazct
changed the title
|
Good job!! Both your use of semantics and the way your code is displayed are great and easy to read! |
Nishka-Kisten
left a comment
Nishka-Kisten
left a comment
There was a problem hiding this comment.
good job on your use of semantics and the way your code is written. very easy to follow
For the horizontal scroll bar, maybe try max-width: 100% to fix that or overflow perhaps as hidden
Thanks, I've made a few adjustments, hopefully it sticks. thanks for pointing it out. |
| <link rel="stylesheet" href="css/style.css" /> | ||
| <link rel="shortcut icon" type="image/x-icon" href="favicon.ico" /> | ||
| </head> | ||
| <body> |
There was a problem hiding this comment.
From the tag body on top of this one, your code is not clear, there is a closing head tag which makes things very hard to figure out, please review everything from the head tag to this body tag,
| <section class="products"> | ||
| <div><h2>Everyone needs a little Karma</h2></div> | ||
|
|
||
| <div class="grid"> |
There was a problem hiding this comment.
Remember we are targeting semantic tags in HTML so better change divs inside the section into articles,
There was a problem hiding this comment.
Hi Mathias, those divs are just there to serve as a division between the other elements for use with Grid. I already made use of the section tag and other semantic tags where needed. I don't really have any articles on the website that's why I didn't use it, Did look at where I can use it though.
| <!-- All the images you need are in the 'img' folder --> | ||
|
|
||
| </body> | ||
| </body> |
There was a problem hiding this comment.
The extra closing body tag is confusing things, please review your first opening body tag to fix this one better,
There was a problem hiding this comment.
The extra closing body tag is confusing things, please review your first opening body tag to fix this one better,
Thanks Mathias, I'll make the adjustment. Nice find, Not sure how I managed that one.
There was a problem hiding this comment.
So i checked through the code on both git and my PC , I don't see the extra body Tag.
I think what you're looking at is the deletion and insertion of the tag from one line to another. hence the red & green highlight.
Mathias02
left a comment
Mathias02
left a comment
There was a problem hiding this comment.
Riyaaz, would you please review my Karma project and suggest changes through a pull request,
shafiekdavids
left a comment
shafiekdavids
left a comment
There was a problem hiding this comment.
Very clear commenting on CSS and html files
Hi Mathias, I've reviewed your project, a bit late as I only found this request a few mins ago. |
|
It's fine thanks Riyaaz |
4 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
Doing the whole webpage is becoming easier.
still getting the hang of flexbox and grid. also getting the image sizes correct was a bit tricky.
Nothing really, I have an idea of what needs to be done so I just play around with things until I get it right.