Skip to content

ZA_2-Nishka-Kisten-CodeYourFuture / HTML-CSS-Module-Project-Week_3 #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nishka-Kisten wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ZA_2-Nishka-Kisten-CodeYourFuture / HTML-CSS-Module-Project-Week_3 #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
203ec7c
Nishka-Kisten
Nishka-Kisten Jun 12, 2022
7ca4cd3
Changes made so code is easier to read.
Nishka-Kisten Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 153 additions & 0 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,157 @@ body {
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/

* { box-sizing: border-box;
margin: 0;
padding: 0;
font-weight: normal;
}
/* NAV STYLES START */

header {
display: flex;
justify-content: space-between;
align-items: center;
padding: 10px 10%;
background-color: #ffffff;

}
.logo{
width: 28px;
cursor: pointer;

}
.nav a{
list-style-type: none;
text-decoration: none;
font-size: 18px ;

}
.nav li {
display: inline-block;
padding: 0px 10px;

}
.main{
color:#5c5f66;

}
.links {
color: #9297a0;
}

.nav li a:hover {
color: #e1643b;
}

/* NAV STYLES END */

/* HERO STYLES START */
.hero_img{
max-width: 100%;
height: auto;

}

h1{
color: #ffffff;
position: absolute;
top: 39%;
left: 44%;
transform: translate(-50%, -50%);
font-size: 65px;

}

.hero_p {
color: #ffffff;
position: absolute;
top: 56%;
left: 44%;
transform: translate(-50%, -50%);
font-size: 33px;
}
.btn{
position:absolute;
top: 70%;
left: 44%;
transform: translate(-50%, -45%);
z-index: 10;
text-decoration: none;
background-color: #e0633a;
border: none;
color: white;
padding: 12px 28px;
display: inline-block;
font-size: 14px;
border-radius: 4px;

}

.btn:hover {
background-color: #c24015;
}

/* HERO STYLES END */

/* GENERAL STYLES START */
h2{
text-align: center;
padding: 40px;
font-size: 50px;
margin-top: 50px;
}
.devices{
width: 120px;

}
.container{
display: flex;
flex-direction:row;
justify-content:space-around;
margin-bottom: 80px ;
font-size: 20px;
text-align:center;
align-content: center;
padding: 20px;
}
.img_p{
margin-top: 20px;
}
/* GENERAL STYLES END */

/* FOOTER START */

hr {
border: none;
border-top: 1px solid lightgray;
width: 80%;
margin:auto;

}

footer{
text-align: center;
margin-top: 20px;
margin-bottom: 80px;
}
.icons{
width:40px;
background-color:#fff;
border:1px solid lightgray;
height:40px;
border-radius:50%;
padding: 10px;
margin:20px 4px;
cursor: pointer;
}

.icons:hover{
filter:contrast(90%);
}

.inc {
color: #9297a0;
}

/* FOOTER END */
49 changes: 44 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,49 @@
<link rel="shortcut icon" type="image/x-icon" href="favicon.ico">
</head>
<body>

<!-- Add your HTML markup here -->
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<!-- All the images you need are in the 'img' folder -->

<header>
<img class="logo" src="/img/karma-logo.svg" alt="logo">
<nav>
<ul class="nav">
<li><a href="#" class="main">Meet Karma</a></li>
<li><a href="#" class="links">How It Works</a></li>
<li><a href="#" class="links">Store</a></li>
<li><a href="#" class="links">Blog</a></li>
<li><a href="#" class="links">Help</a></li>
<li><a href="#" class="links">Login</a></li>
</ul>
</nav>
</header>
<section>
<img class="hero_img" src="/img/first-background.jpg">
<h1>Introducing Karma</h1>
<p class="hero_p">Bring WiFi with you, everywhere you go.</p>
<button class="btn">Learn More</button>
</section>
<h2>Everyone needs a little Karma.</h2>
Copy link
Copy Markdown

@Mathias02 Mathias02 Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This h2 is left alone who's child is it here? please get it a parent,

<section class="container">
Copy link
Copy Markdown

@Mathias02 Mathias02 Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing these divs inside your section into articles would be something better than keeping divs

<div>
<img class="devices" src="/img/icon-devices.svg">
<p class="img_p">Internet for all devices</p>
</div>
<div>
<img class="devices" src="/img/icon-coffee.svg">
<p class="img_p">Boost your productivity</p>
</div>
<div>
<img class="devices" src="/img/icon-refill.svg">
<p class="img_p">Pay as You Go</p>
</div>
</section>
<hr>
<footer>
<p>Join us on</p>
<div>
<a href="#" ></a> <img class="icons" src="/img/twitter-icon.svg"></a>
<img class="icons" src="/img/facebook-icon.svg">
<img class="icons" src="/img/instagram-icon.svg">
<p class="inc"> &copy Karma Mobility, Inc.</p>
</div>
</footer>
</body>
</html>