-
-
Notifications
You must be signed in to change notification settings - Fork 620
ZA2 Patou Mabando / HTML-CSS-Module-Project #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,94 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> | ||
| <title>Karma</title> | ||
| <link href='https://fonts.googleapis.com/css?family=Roboto:400,500,300' rel='stylesheet' type='text/css'> | ||
| <link rel="stylesheet" href="css/normalize.css"> | ||
| <link rel="stylesheet" href="css/style.css"> | ||
| <link rel="shortcut icon" type="image/x-icon" href="favicon.ico"> | ||
| <link rel="shortcut icon" type="image/x-icon" href="favicon.ico"> | ||
| </head> | ||
| <body> | ||
|
|
||
| <!-- Add your HTML markup here --> | ||
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
| <body> | ||
|
|
||
| <!-- Add your HTML markup here --> | ||
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
| <header> | ||
| <div class="header container"> | ||
| <nav> | ||
| <img src="img/karma-logo.svg" alt="logo" class="logo"> | ||
| <ul> | ||
| <li>Meet karma</li> | ||
| <li><a href="#hero">How it Works</a></li> | ||
| <li><a href="#">Store</a></li> | ||
| <li><a href="#">Blog</a></li> | ||
| <li><a href="#">Help</a></li> | ||
| <li><a href="#">Login</a></li> | ||
| </ul> | ||
| </nav> | ||
| </div> | ||
| </header> | ||
| <!--end Header --> | ||
|
|
||
| <!-- hero section --> | ||
| <main> | ||
| <section id="hero"> | ||
| <div class="hero-container"> | ||
|
|
||
| <h1>Introducing Karma</h1> | ||
| <p>Bring Wifi with you, everywhere you go.</p> | ||
| <a href="#Howitworks" type="button" class="btn">Learn More</a> | ||
| </div> | ||
| </section> | ||
|
|
||
| <section class="content"> | ||
| <h2>Everyone needs a little Karma.</h2> | ||
|
|
||
| <ul class="karma"> | ||
| <figure> | ||
| <li><img src="img/icon-devices.svg" alt="icon-devices" height="128" width="128"></li> | ||
| <figcaption>Internet for all devices</figcaption> | ||
| </figure> | ||
|
|
||
| <figure> | ||
| <li><img src="img/icon-coffee.svg" alt="icon-coffee" height="128" width="128"></li> | ||
| <figcaption>Boost your productivity</figcaption> | ||
| </figure> | ||
|
|
||
| <figure> | ||
| <li><img src="img/icon-refill.svg" alt="icon-refill" height="128" width="128"></li> | ||
| <figcaption>Pay as You Go</figcaption> | ||
| </figure> | ||
|
|
||
| </ul> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Writing your ul inside your figure tag would be much better than keeping it outside the figure, please re-organize your HTML structure in this area,
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can You please suggest to me how I can write it down please. Thanks |
||
|
|
||
| </section> | ||
| </main> | ||
|
|
||
| <hr> | ||
|
|
||
| <footer> | ||
| <div class="footer-content"> | ||
| <h3>Join us on</h3> | ||
| <ul> | ||
| <li><a href="#"><img class="socials-icon" src="img/twitter-icon.svg" alt="twitter-icon" width="50pt" | ||
| height="50pt"></a></li> | ||
|
|
||
| <li><a href="#"><img class="socials-icon" src="img/facebook-icon.svg" alt="facebook-icon" | ||
| width="50pt" height="50pt"></a></li> | ||
| <li><a href="#"><img class="socials-icon" src="img/instagram-icon.svg" alt="instagram-icon" | ||
| width="50pt" height="50pt"></a></li> | ||
| </ul> | ||
| <p>©Karma Mobility, Inc.</p> | ||
| </div> | ||
| </footer> | ||
|
|
||
| </body> | ||
|
|
||
| </html> | ||
| </body> | ||
|
|
||
| </html> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This div with the class header container is not looking good, however, your header must a least have 2 child elements, the logo, and the nav list, organizing it this way will make your CSS much clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can You please suggest to me how I can write it down please. Thanks