WM4 CodeYourFuture / HTML-CSS-Module-Project (Karma clone)#380
WM4 CodeYourFuture / HTML-CSS-Module-Project (Karma clone)#380dewayne51 wants to merge 16 commits into
Conversation
dewayne51
changed the title
dewayne51
changed the title
magarpratik
left a comment
magarpratik
left a comment
There was a problem hiding this comment.
Really impressed with your work. You have completed all the tasks and also attempted stretch goals. Well done! The quality of the work is really high.
|
|
||
| <section class="second_section"> | ||
|
|
||
| <div1> |
|
|
||
|
|
||
|
|
||
| <header> |
There was a problem hiding this comment.
The code is not indented consistently which makes it harder to read.
You can use Prettier which automatically indents code for you.
You can read about our code style guide here https://syllabus.codeyourfuture.io/guides/code-style-guide
|
|
||
|
|
||
| <div class="storeimg"> | ||
| <img src="/img/store-image_by-andrew-neel-unsplash.jpg" alt="" height="1235" width="700" /> |
There was a problem hiding this comment.
you should add an alt description here, which is good for accessibility.
But, you've done it for all other img elements. Good job for that!
| <div> | ||
| <h1 class="storehdr">Order your Karma Wifi device today!</h1> | ||
| </div> | ||
| <div style="float:left;" class="item"> |
There was a problem hiding this comment.
Using float is not generally recommended.
I am not too sure why as I'm not very familiar with CSS myself.
I found an interesting discussion in stackoverflow https://stackoverflow.com/questions/9776840/is-float-for-layout-bad-what-should-be-used-in-its-place
| </main> | ||
|
|
||
|
|
||
| <footer class="footer"> |
There was a problem hiding this comment.
using class attribute here is redundant because can directly target the footer element in your CSS.
|
|
||
| </footer> | ||
|
|
||
| </section> |
There was a problem hiding this comment.
I think this closing section tag should be moved to line 96.
| © Karma Mobility, Inc. | ||
| </p> | ||
|
|
||
| </footer> |
2 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? using git desktop to commit / push folders
What did you find hard? positioning and sizing images/objects, lack of time/mental energy to focus on assignment after work
What do you still not understand? the multitude of functions to position and size objects via html/css
Any other notes?