NW5-Khadar-M-Dagal-Karma-Project#441
Conversation
Fix the background image size so it can appear as required
1 Change background-size to cover value. 2 change the size of the original background image in the repo
Link store & index
and aria-required to assist visually impaired users to know this field is required.
haroon-ali-dev
left a comment
haroon-ali-dev
left a comment
There was a problem hiding this comment.
I have stated all changes that need to be made.
Ara225
left a comment
Ara225
left a comment
There was a problem hiding this comment.
Overall pretty brillant Really love the detailed commit messages and the comments. Thesee are the sort of things that really make a diffrence for people reading your code. Couple small notes on the code side of things; it's mostly really solid production grade stuff However, the look is a bit off for me see the linked image below
| /* ----------------------------------------------------------------------- */ | ||
| /* -----------this section is store page--------- */ | ||
|
|
||
| /* main section, this code helps the form and picture layout side-by-side */ |
| height: inherit; | ||
| left: 739px; | ||
| top: 98px; | ||
| top: 90px; |
There was a problem hiding this comment.
Better to use em or rem units if possible
|
|
||
| <section class="store_main_section"> | ||
| <div class="form_container"> | ||
| <fieldset class="form_container"> |
There was a problem hiding this comment.
fieldset is best used around a group of radio buttons for accessability see https://syllabus.codeyourfuture.io/html-css/week-2/lesson#radio-input-fields https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset
3 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?