Glasgow Class 6 - Malkit Benning - HTML/CSS Module Project - Week 2#553
Open
malkitbenning wants to merge 11 commits into
Open
Glasgow Class 6 - Malkit Benning - HTML/CSS Module Project - Week 2#553malkitbenning wants to merge 11 commits into
malkitbenning wants to merge 11 commits into
Conversation
top nav, hero section, main icons and footer done
fixed sizing of list box using percentages
Up to terms and conditions.
added 'after' to alter radio button colour
checkbox tick working, but radio button not working properly
last step for week 2 changes done. Custom radio buttons using before and after in css
malkitbenning
changed the title
made responsive changes by creating a mobile version of main page
fields now on top of each other for mobile view. Still need to fix navigation to do something when hamburger icon clicked
burger menu working responsive mobile design for main karma page as well as store page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details
Notes
What did you find easy?
Week 2
Starting to see the benefits of flexbox
Week 3
Understanding more CSS
What did you find hard?
Week 2
elements, especially images, behaviour when browser stretched is confusing.
Week 3
Making the burger menu work
What do you still not understand?
Week 2
If my approximations for sizes are ok, or if I didn't see instructions which gave more precise guidance on how to get the proportions correct of the required layout.
Still not sure about how to stretch browser and retain required results.
Week 3
Not sure if I've done enough changes
Any other notes?