London10 - Olha_Danylevska - Karma_Project - week_2#571
Open
OlhaDanylevska wants to merge 11 commits into
Open
London10 - Olha_Danylevska - Karma_Project - week_2#571OlhaDanylevska wants to merge 11 commits into
OlhaDanylevska wants to merge 11 commits into
Conversation
Added nav and header to HTML and some CSS
Added icons in main section in HTML
Added CSS to main icons
Added footer and CSS for elements
added CSS grid
Added CSS Grid to <div class="connect"> <div class="connect_text">
form on store page
Store page customer form
style radio buttons and chackbox
Finished Karma project finished mobile
AnnaFYZ
reviewed
Feb 19, 2023
| <main> | ||
| <div class="container_store"> | ||
|
|
||
| <div class="form"> |
There was a problem hiding this comment.
it is also common tag for this case
instead of making form in tag.
AnnaFYZ
reviewed
Feb 19, 2023
| <input type="text" name="first-name" id="first-name" required> | ||
| </div> | ||
| <div class="last-name"> | ||
| <label for="last-name">Last Name*</lable><br> |
There was a problem hiding this comment.
if you display div class="first-name" as block in css you would not need to use to separate them
|
|
||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
i find it useful to write comments before each part of styling code, which explains what part of html is going to be styled or what is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?